XWIKI-2470: Improve saving to not save data that has not changed #4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove duplicated code between SaveAction and SaveAndContinueAction that builds the JSON response. Put the "JSON" map object on the XWiki context and let various parts of the code add stuff that needs to be returned to the editor. * Remove the redirect object before updating the authors, in order to be able to detect if the document is dirty before the authors are set. * Move the line that sets the metadata dirty right before saving, because it is needed only to force incrementing the version. * Small code improvements and more comments added. * Let the editor know when the save doesn't create a new revision in order to not show the "Saved" notification because it can mislead the user into thinking that a new version was created. * Add page objects for the history dropdown from the realtime toolbar. * Add functional test. * Don't propagate the version on save (to the other collaborators) if there's no new version. * Bulletproof the history dropdown to not duplicate versions.
michitux
reviewed
Oct 17, 2025
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAction.java
Outdated
Show resolved
Hide resolved
michitux
reviewed
Oct 17, 2025
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAction.java
Show resolved
Hide resolved
tmortagne
reviewed
Oct 17, 2025
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAction.java
Show resolved
Hide resolved
* Return the new (latest) version even when we don't create a new revision because the editor that sent the save request might have an outdated version number. This can happen if two users save the same document state, either because they didn't modify the document or because they made the same modifications. * Update since version * Fix RealtimeEditToolbar#waitForConcurrentEditingWarning() that was causing both the existing #editFullScreen() test and the new #preventEmptyRevisions() test to flicker (we need to wait for the fade-in / fade-out popover animation to end). * Display the revision author, not modifier (last content updater), in the history dropdown. * The auto-saver should check if the new version is different from the current version. * Extend the #preventEmptyRevisions() functional test to check what happens when both users save the same document state. * Simplify the version update handler in actionButtons.js * Modify meta.js to not trigger the 'xwiki:document:changeVersion' event if the version didn't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-2470
Changes
Executed Tests
All realtime editing tests, for Firefox and Chrome.
Expected merging strategy