XWIKI-20953: Edit autosave frequency visibility #4682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP, somehow the js fails...
* Updated CSS * Fixed the error in the .js * Moved a flamingo patch to the main CSS of this element (since flamingo is supposed to be the main now anyways).
* Moved a flamingo patch to the main CSS of this element (since flamingo is supposed to be the main now anyways).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-20953
Changes
Description
frequencyoccurences tointervalsince a frequency is not measured in minutes... (and the change of translation key made it easy to do right now :) )autosave.jsScreenshots & Video
Here is the new look of the input:
This is surely not a flawless design, but it fixes the main usability issue without moving too far from what it was.
Executed Tests
Manual tests, see screenshots above.
Could not find the autosave frequency input in the expected page object:
xwiki-platform/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/editor/EditPage.java
Lines 58 to 59 in b646b33
Expected merging strategy