Skip to content

Conversation

@Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Oct 20, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-23496

Changes

Description

  • Added a style to avoid the unexpected layout at very high viewport width.

Clarifications

  • By making the width relative to the parent size, we make sure the form will take its own column in the facet display. This way, we avoid having the weird display that was showcased in the issue description.
  • It slightly moved the form even in regular conditions, but IMO it's alright and it makes it clearer that the form is under the checkbox in the hierarchy. See the screenshots below

Screenshots & Video

Here are a couple of pairs of screenshots of the impacted UI. I just searched the page string on my default instance and selected the custom date range picker to see this:
Before the PR:
extra large viewport
Screenshot from 2025-10-20 11-07-05
regular viewport
image

After the PR:
extra large viewport
Screenshot from 2025-10-20 11-08-18
regular viewport
image

Executed Tests

Manual tests, see above.
This is a low impact style only change (low importance on a very limited scope) so I figured it wouldn't have any impact on docker or functional tests.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None.

* Added a style to avoid the unexpected layout at very high viewport width.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant