Use dominant-baseline if alignment-baseline is missing & Apply context on text nodes#286
Draft
giroletm wants to merge 1 commit into
Draft
Use dominant-baseline if alignment-baseline is missing & Apply context on text nodes#286giroletm wants to merge 1 commit into
giroletm wants to merge 1 commit into
Conversation
giroletm
changed the title
text nodes
giroletm
changed the title
text nodes
HackbrettXXX
requested changes
Sep 24, 2024
Member
HackbrettXXX
left a comment
HackbrettXXX
left a comment
There was a problem hiding this comment.
Thank you for the PR. Please add a test case.
…ctx fix Fixes yWorks#80 Applies the current context before rendering a text node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80 by falling back on
dominant-baselineifalignment-baselineis unspecified.Note that according to MDN, if
dominant-baselineis defined within a parent and a child sets itsalignment-baselinetobaseline, it should be equivalent to the same value as the parent'sdominant-baseline.This specific case is not supported here. All this PR does is allow the usage of
dominant-baselineontextnodes. Child nodes are not considered.This PR also applies the current context before rendering a
textnode, since this was previously not done, causing adjacenttextnodes that uses different font styles to use the same one.