Open
Conversation
66d2c1d to
4da43a6
Compare
8e1d80d to
8cf0978
Compare
the funtion should have a return value Signed-off-by: Yadong Qi <yadong.qi@intel.com>
wait_cnt always 0 if defined in while loop. Move the definition out of loop scope. Signed-off-by: Yadong Qi <yadong.qi@intel.com>
The virtual function should be called with explicitly qualified ID in constructor/deconstructor. Signed-off-by: Yadong Qi <yadong.qi@intel.com>
enable queries: security-extended,security-and-quality Signed-off-by: Yadong Qi <yadong.qi@intel.com>
62fe082 to
4499e26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable queries: security-extended,security-and-quality
Signed-off-by: Yadong Qi yadong.qi@intel.com