Fix params allowed_updates on Telegram bot polling whenever it's an array #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfanzain
changed the title
alfanzain
force-pushed
the
fix/stringify-allowed-updates-on-get-updates
branch
from
bdfcb68 to
a6d38d3
Compare
|
I've created this PR to fix #1266 For more detailed context #1266 (comment) |
alfanzain
force-pushed
the
fix/stringify-allowed-updates-on-get-updates
branch
from
a6d38d3 to
960d348
Compare
alfanzain
force-pushed
the
fix/stringify-allowed-updates-on-get-updates
branch
from
960d348 to
afc13e1
Compare
alfanzain
force-pushed
the
fix/stringify-allowed-updates-on-get-updates
branch
from
afc13e1 to
9478054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masternpm run docDescription
The bot was not receiving updates for
message_reactionevents, even thoughallowed_updateswas specified in the polling config.Turns out, the
allowed_updatesparameter was not being correctly passed to thegetUpdatescall if it is an array. It needs to be JSON-stringified.This PR fixes the polling configuration to ensure that
allowed_updatesis properly passed as an array to thegetUpdatesmethod.References