perf(profiler): reserve(1+|pids|) for errs slice — eliminate O(log n) reallocations in Flush#97
Open
KorsarOfficial wants to merge 1 commit into
Open
Conversation
42fbc7a to
d82d914
Compare
Author
|
📄 Full analysis report (PDF): 08-perforator-optimizations.pdf Covers complexity analysis, concurrency audit, and verification for all 7 optimizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
Complexity analysis
Let k =
len(c.p.pids)(number of tracked PIDs).appendreallocationsThe standard Go
appenddoubling strategy meansmake([]error, 0)triggers reallocations at sizes 1, 2, 4, 8 … up to 1+k. With a correct capacity hint the backing array is allocated once at the final size.Change
The bound
1 + len(c.p.pids)is tight: at most one error fromwholeSystemflush + one per PID consumer.