Skip to content

DRAFT: 5-Color THT Resistor - #156

Closed
Electro707 wants to merge 4 commits into
yaqwsx:masterfrom
Electro707:feature_res_bands
Closed

DRAFT: 5-Color THT Resistor#156
Electro707 wants to merge 4 commits into
yaqwsx:masterfrom
Electro707:feature_res_bands

Conversation

@Electro707

Copy link
Copy Markdown
Contributor

This PR adds the ability for 5-band resistor color codes.

This should address most issues in #141

Related to yaqwsx/PcbDraw-Lib#39, which needs to be merged first as this PR depends on it

@Electro707
Electro707 marked this pull request as draft January 1, 2024 02:08
@yaqwsx
yaqwsx force-pushed the master branch 2 times, most recently from 51ee017 to d2af9d4 Compare March 25, 2024 06:39
Moved around resistor tolerance values, added 0.01% and 0.02%
Fix bug where a value of `R` alone would count as 0 ohms
Fixed lxml to ==4.9.4, as the newest 5.0.0 version breaks this tool
@yaqwsx

yaqwsx commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Thanks for the work on this. The functionality proposed here has now been implemented upstream as part of the current resistor-color rewrite: four- and five-band codes, tol/tolerance fields, 20% tolerance, zero-ohm and low-ohm handling, precision tolerances, and expanded DIN axial footprint coverage are covered by commits 9b732de, 10813d1, and footprint-library commit 4183822. The implementation no longer depends on pcbnew, and the attached test board from #141 renders without resistor or missing-footprint warnings. Since this PR is now superseded, I’m closing it. Thanks again for providing the original implementation and design direction.

@yaqwsx yaqwsx closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants