feat(why): allow specifying a version or range #6992
Conversation
Signed-off-by: Remy Parzinski <[email protected]>
Signed-off-by: Remy Parzinski <[email protected]>
|
@arcanis are you available to review this? You refactored |
There was a problem hiding this comment.
Do not use the release-date package name here. They have release time information attached to them at the package server level to test related features (e.g. npmMinimalAgeGate). Using that name here is just confusing. Reuse/create one of the generic ones like one-fixed-dep.
| `Explain why version 3.3.1 of lodash is in your project`, | ||
| `$0 why [email protected]`, | ||
| ], [ | ||
| `or why version 3.X of lodash is in your project`, |
There was a problem hiding this comment.
| `or why version 3.X of lodash is in your project`, | |
| `Explain why version 3.x of lodash is in your project`, |
| function isSameIdent(pkg: Ident, targetPkg: Ident) { | ||
| return pkg.identHash === targetPkg.identHash; | ||
| } |
There was a problem hiding this comment.
This function already exists as structUtils.areIdentsEqual. But honestly, I think just inlining this is much more readable
| if (!isSameIdent(nextPkg, targetPkg)) | ||
| continue; | ||
|
|
||
| if (!structUtils.isPackageInRange(nextPkg, targetPkg.range)) |
There was a problem hiding this comment.
This only works for semver ranges, right? What happens if the given descriptor's range is non-semver? Either way, I think that should fail-fast above, when parsing the descriptor.
| seen.add(pkg.locatorHash); | ||
|
|
||
| if (pkg.identHash === identHash) { | ||
| if (isSameIdent(pkg, targetPkg)) { |
There was a problem hiding this comment.
I think you can just can in-range-ness here and eliminate the checks below? Or is there an edge case I am not considering?
2 participants
What's the problem this PR addresses?
Allowing users to specify a version or range for
yarn whyto find out why a specific version appears in the dependency tree. This is particularly useful if you want to address CVEs.Closes #6859
How did you fix it?
Checklist