Skip to content

fix: added proper state management and route verification of dashboard #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 12, 2025
Merged

fix: added proper state management and route verification of dashboard #117

merged 5 commits into from
Feb 12, 2025

Conversation

ARYPROGRAMMER
Copy link
Contributor

Pull Request Template

Summary

This Issue fixes the bugs present in dashboard page

Fixes #116

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots/Videos (optional)

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025

@ARYPROGRAMMER is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ARYPROGRAMMER
Copy link
Contributor Author

@yashksaini-coder please review and merge. Let me know if any more problems, i can split in parts and update

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leetcode-journal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 0:39am

@yashksaini-coder yashksaini-coder added bug Something isn't working SWOC officially part of SWOC season 5 Backend Related to the Backend part High Priority High Priority issue labels Feb 10, 2025
@yashksaini-coder
Copy link
Owner

image

@ARYPROGRAMMER kindly check and fix this

@ARYPROGRAMMER
Copy link
Contributor Author

image

@ARYPROGRAMMER kindly check and fix this

Some time to check

@ARYPROGRAMMER
fixture
033b26e 
Signed-off-by: Arya Pratap Singh <[email protected]>
@yashksaini-coder
Copy link
Owner

yashksaini-coder commented Feb 12, 2025 •
edited
Loading

@ARYPROGRAMMER still issues in the build, kindly try updating the prisma and prisma/client to the latest version and check the build locally.

image

image

image

@yashksaini-coder yashksaini-coder added the Under Review The Pull Request is under Review label Feb 12, 2025
yashksaini-coder
yashksaini-coder reviewed Feb 12, 2025
View reviewed changes
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to fix the build @ARYPROGRAMMER

@ARYPROGRAMMER
Copy link
Contributor Author

Try to fix the build @ARYPROGRAMMER

sure some time to fully check this

@yashksaini-coder
Copy link
Owner

Try to fix the build @ARYPROGRAMMER

sure some time to fully check this

yeah okh, npm run build command to check the build locally. and make sure the prisma is updated

@ARYPROGRAMMER
Copy link
Contributor Author

Try to fix the build @ARYPROGRAMMER

sure some time to fully check this

yeah okh, npm run build command to check the build locally. and make sure the prisma is updated

yeah would check this, search param use is incorrect it needs a suspense wrapper in register route figured that

@ARYPROGRAMMER
full-fixed
9abf37d 
Signed-off-by: Arya Pratap Singh <[email protected]>
@ARYPROGRAMMER
Copy link
Contributor Author

@yashksaini-coder all done lgtm

@yashksaini-coder
Copy link
Owner

bro there are new changes merged and deployed. Your PR build is fine but it doesn't have the updated changes. Raise a new PR and delete this branch @ARYPROGRAMMER

yashksaini-coder
yashksaini-coder reviewed Feb 12, 2025
View reviewed changes
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new changes and updates are not update

@ARYPROGRAMMER
Copy link
Contributor Author

oh sure sure

bro there are new changes merged and deployed. Your PR build is fine but it doesn't have the updated changes. Raise a new PR and delete this branch @ARYPROGRAMMER

@ARYPROGRAMMER
Copy link
Contributor Author

it does not have conflicts tho

@ARYPROGRAMMER
Copy link
Contributor Author

ARYPROGRAMMER commented Feb 12, 2025 •
edited
Loading

@yashksaini-coder will this work?

added : merge commit itself [branch insync]

yashksaini-coder
yashksaini-coder approved these changes Feb 12, 2025
View reviewed changes
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL good

@yashksaini-coder yashksaini-coder merged commit a7d6189 into yashksaini-coder:main Feb 12, 2025
4 checks passed
@yashksaini-coder yashksaini-coder added Advanced SWOC Level 3 issue Points Assigned The points have been assigned on OS Lead and removed Under Review The Pull Request is under Review labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashksaini-coder yashksaini-coder yashksaini-coder approved these changes

Assignees

@ARYPROGRAMMER ARYPROGRAMMER

Labels
Advanced SWOC Level 3 issue Backend Related to the Backend part bug Something isn't working High Priority High Priority issue Points Assigned The points have been assigned on OS Lead SWOC officially part of SWOC season 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Dashboard reroute
2 participants
@ARYPROGRAMMER @yashksaini-coder