Skip to content

[Disk Manager] Introduce Cells component#3618

Merged
Rattysed merged 6 commits intomainfrom
users/rattysed/issue-3614-introduce-shards-service
Jun 7, 2025
Merged

[Disk Manager] Introduce Cells component#3618
Rattysed merged 6 commits intomainfrom
users/rattysed/issue-3614-introduce-shards-service

Conversation

@Rattysed
Copy link
Copy Markdown
Collaborator

@Rattysed Rattysed commented Jun 3, 2025 •
edited
Loading

#3614

We introduce a new component to manage cell selection when creating disks. By default, disks are created in the first cell defined in the configuration.

Added features:

  • CellSelector: a new component used by DiskService to select the target cell before disk creation.
  • Default selection strategy: always use the first cell from the configuration.

@Rattysed Rattysed added large-tests Launch large tests for PR disk_manager Add this label to run only cloud/disk_manager build and tests on PR labels Jun 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ad20ab4.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1098 1098 0 0 0 0

BarkovBG
BarkovBG previously approved these changes Jun 4, 2025
View reviewed changes
SvartMetal
SvartMetal reviewed Jun 4, 2025
View reviewed changes
Comment thread cloud/disk_manager/internal/pkg/services/shards/config/config.proto Outdated
@Rattysed Rattysed force-pushed the users/rattysed/issue-3614-introduce-shards-service branch from ad20ab4 to 2c3a00e Compare June 5, 2025 14:21
@Rattysed Rattysed changed the title [Disk Manager] Introduce Shards service [Disk Manager] Introduce Cells component Jun 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 8b58859.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1098 1097 0 0 0 1

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 8b58859.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 43 0 0 0 0

BarkovBG
BarkovBG previously approved these changes Jun 6, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1a00b6b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1098 1097 0 0 0 1

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1a00b6b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 42 0 0 0 1

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1a00b6b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 43 0 0 0 0

@Rattysed Rattysed requested a review from SvartMetal June 6, 2025 11:20
@Rattysed Rattysed requested a review from BarkovBG June 6, 2025 14:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ae7544b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1098 1098 0 0 0 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b6c1baf.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1098 1097 0 0 0 1

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b6c1baf.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 43 0 0 0 0

SvartMetal
SvartMetal requested changes Jun 6, 2025
View reviewed changes
Comment thread cloud/disk_manager/internal/pkg/cells/cells.go Outdated
Comment thread cloud/disk_manager/internal/pkg/cells/config/config.proto Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 376fc10.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1098 1097 0 0 0 1

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 376fc10.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 42 0 0 0 1

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 376fc10.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 43 0 0 0 0

@Rattysed Rattysed merged commit af4629a into main Jun 7, 2025
11 of 12 checks passed
@Rattysed Rattysed deleted the users/rattysed/issue-3614-introduce-shards-service branch June 7, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SvartMetal SvartMetal SvartMetal approved these changes

@BarkovBG BarkovBG BarkovBG approved these changes

Assignees

No one assigned

Labels

disk_manager Add this label to run only cloud/disk_manager build and tests on PR large-tests Launch large tests for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rattysed @SvartMetal @BarkovBG