Live migration to the new leader volume. #4448
Open
+907
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbasic
added
large-tests
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
4 times, most recently
from
91f5637 to
598fef6
Compare
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
7 times, most recently
from
91953ab to
5e9c5b6
Compare
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
4 times, most recently
from
a3e4e47 to
c2e7af8
Compare
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
2 times, most recently
from
9f42d2a to
f19bbe7
Compare
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
from
f19bbe7 to
658b347
Compare
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
from
8a2038d to
4f5b415
Compare
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 4f5b415.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 4f5b415.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 4f5b415.
|
drbasic
force-pushed
the
users/drbasic/mount-secondary-volume-2
branch
from
4f5b415 to
080b5b0
Compare
komarevtsev-d
approved these changes
Oct 31, 2025
sharpeye
reviewed
Nov 2, 2025
Comment on lines
+638
to
+648
| if (response.GetVolume().GetPrincipalDiskId()) { | ||
| Y_DEBUG_ABORT_UNLESS( | ||
| response.GetVolume().GetPrincipalDiskId() == | ||
| NStorage::GetNextDiskId(response.GetVolume().GetDiskId())); | ||
|
|
||
| if (auto switcher = SessionSwitcherPtr.lock()) { | ||
| switcher->SwitchSession( | ||
| response.GetVolume().GetDiskId(), | ||
| response.GetVolume().GetPrincipalDiskId()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Кажется, это можно положить в TSessionManager: обёрткой над клиентом обрабатывать Mount/Read/Write/Zero. Не нужно будет трогать TSession.
There was a problem hiding this comment.
сомневаюсь, эти ошибки монтирования возникают в процессе работы, и их ретраит сама сессия.
There was a problem hiding this comment.
Я про такую конструкцию https://pastebin.com/5PKEfqig
There was a problem hiding this comment.
Да, теперь понял идею. Попробую
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue #2999
Implemented live session switching to a new disk.