[NBS-6247]: Extend TDurableClient retry logic with optional whitelist #4457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drbasic
reviewed
Oct 9, 2025
drbasic
requested changes
Oct 9, 2025
efimov-ivan-yteam
force-pushed
the
users/efimov-ivan/NBS-6247-2
branch
from
85ab56a to
feec364
Compare
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit feec364.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit feec364.
|
efimov-ivan-yteam
force-pushed
the
users/efimov-ivan/NBS-6247-2
branch
from
feec364 to
b31b971
Compare
Contributor
drbasic
requested changes
Oct 14, 2025
drbasic
reviewed
Oct 14, 2025
efimov-ivan-yteam
force-pushed
the
users/efimov-ivan/NBS-6247-2
branch
from
b31b971 to
2c490a9
Compare
Contributor
drbasic
reviewed
Oct 14, 2025
drbasic
reviewed
Oct 14, 2025
drbasic
reviewed
Oct 16, 2025
efimov-ivan-yteam
force-pushed
the
users/efimov-ivan/NBS-6247-2
branch
from
2c490a9 to
11bf7fd
Compare
Contributor
efimov-ivan-yteam
force-pushed
the
users/efimov-ivan/NBS-6247-2
branch
from
11bf7fd to
3c0bcbf
Compare
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3c0bcbf.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 3c0bcbf.
|
EvgeniyKozev
added
large-tests
Contributor
efimov-ivan-yteam
added
the
recheck
github-actions
bot
removed
the
recheck
Contributor
neihar
approved these changes
Oct 31, 2025
drbasic
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional on-error retry layer into
TDurableClientas an optional featureFeature flag: client.proto::EnableListBasedRetryRules
If disabled (default),
EErrorKind::ErrorRetriable-based predicate is used.If enabled,
TDurableClientwill additionally retry all error except:For all media:
cloud/blockstore/libs/client/durable.cpp::NeverRetriableErrors[]For reliable media:
NonRetriableErrorsForReliableMedia[]For non-reliable media:
NonRetriableErrorsForUnreliableMedia[].Configuration:
Lists of non-retriable errors that will not be retried even if
EnableListBasedRetryRulesis set:For disks with
IsReliableMediaKind == true:For disks with
IsReliableMediaKind == false:Добавление в
TDurableClientдополнительного "слоя" retry ошибок в виде опциональной фичи.Feature flag: client.proto::EnableListBasedRetryRules
Если выключен (по умолчанию), используется
EErrorKind::ErrorRetriable-based правило.Если включен,
TDurableClientтакже будет ретраить все ошибки кроме:Для всех дисков:
cloud/blockstore/libs/client/durable.cpp::NeverRetriableErrors[]Для reliable дисков:
NonRetriableErrorsForReliableMedia[]Для non-reliable дисков:
NonRetriableErrorsForUnreliableMedia[].Конфигурация:
Список ошибок, которые не будут ретраиться даже если
EnableListBasedRetryRulesвключен:Для дисков с
IsReliableMediaKind == true:Для дисков с
IsReliableMediaKind == false: