[Disk Manager] Inroduce Cells metrics #4538
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rattysed
added
large-tests
Contributor
Rattysed
force-pushed
the
users/rattysed/issue-3614-metrics
branch
from
9c7d919 to
a9784f3
Compare
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit a9784f3.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit a9784f3.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit a9784f3.
|
jkuradobery
reviewed
Nov 7, 2025
| ticker := time.NewTicker(t.metricsCollectionInterval) | ||
| defer ticker.Stop() | ||
|
|
||
| for range ticker.C { |
jkuradobery
reviewed
Nov 7, 2025
| return nil | ||
| } | ||
|
|
||
| func (t *collectCellsMetricsTask) cleanupMetrics( |
Collaborator
There was a problem hiding this comment.
А зачем занулять метрики? С зависшими тасками это имело смысл, тут - нет.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3614
Add metrics for cells mechanism
Add Free/Total bytes metric, add timeSinceLastUpdate metric