Skip to content

issue-1751: [Filestore] WriteBackCache should support >=4GB capacity #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

issue-1751: [Filestore] WriteBackCache should support >=4GB capacity #4546

wants to merge 3 commits into from

Conversation

@e673
Copy link
Collaborator

@e673 e673 commented Oct 24, 2025 •
edited
Loading

Main issue: #1751
Related PR: #3734

@e673 e673 requested a review from SvartMetal October 24, 2025 10:51
@github-actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit faff79f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9456 9455 0 0 0 1 0

SvartMetal
SvartMetal reviewed Oct 24, 2025
View reviewed changes
cloud/filestore/libs/vfs_fuse/fs_ut.cpp Outdated
features,
1000,
1000,
4_GB + 1); // writeBackCacheCapacity
Copy link
Collaborator

@SvartMetal SvartMetal Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ 100500

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не очень понятно почему.
Но в любом случае, подойдёт любое число, которое меньше, чем 1024 * 1024 + 1024.

@e673 e673 requested a review from SvartMetal October 24, 2025 18:27
@github-actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5a474ca.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9456 9455 0 0 0 1 0

@e673 e673 added the filestore Add this label to run only cloud/filestore build and tests on PR label Oct 27, 2025
@github-actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5a474ca.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3132 3132 0 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SvartMetal SvartMetal Awaiting requested review from SvartMetal

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

filestore Add this label to run only cloud/filestore build and tests on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e673 @SvartMetal