Introduce TBlockStoreMethod template #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

drbasic merged 2 commits into main from users/drbasic/block-store-template-method

Oct 27, 2025

Collaborator

drbasic commented Oct 25, 2025 •

edited

Loading

The main idea is to make for each type of requests enumerated by the BLOCKSTORE_SERVICE macro (NProto::TReadBlocksRequest, NProto::TCreateCheckPointRequest, etc.) your template TBlockStoreMethod<TRequest, TResponse>
In this template TBlockStoreMethod, there will be convenient access to the types of request and response, the name of the request, and some query classifications, for example, IsReadWriteRequest()
Such a template TBlockStoreMethod is easy to get by request type or response type.
TBlockStoreMethod allows you to call the desired method from the IBlockStore
TBlockStoreImpl does the opposite transformation, inherits from IBlockStore, and when calling the virtual method, IBlockStore dispatches the call to the template method of the user class, immediately passing the TBlockStoreMethod type to it in the template. Which allows you to write IBlockStore heirs without macros.


          Introduce TBlockStoreMethod template

3c590aa

drbasic added the blockstore label

drbasic commented

View reviewed changes

cloud/blockstore/libs/client/client.cpp Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/client/client.cpp Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/client/switchable_client.cpp Outdated Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/client/switchable_client.cpp Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/client/switchable_client.cpp Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/service/service_method.h Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/service/service_method.h Show resolved Hide resolved

drbasic commented

View reviewed changes

cloud/blockstore/libs/service/service_method.h Show resolved Hide resolved

Contributor

github-actions bot commented Oct 25, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 3c590aa.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
5458	5457	0	0	0	1	0

sharpeye previously approved these changes

View reviewed changes


          Fix review issues

f4963c9

drbasic dismissed sharpeye’s stale review via

f4963c9

October 27, 2025 14:08

sharpeye approved these changes

View reviewed changes

komarevtsev-d approved these changes

View reviewed changes

Contributor

github-actions bot commented Oct 27, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit f4963c9.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
5458	5457	0	0	0	1	0

drbasic merged commit 35fd5f3 into main

12 of 14 checks passed

drbasic deleted the users/drbasic/block-store-template-method branch

October 27, 2025 14:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels