Skip to content

update caching and ci behaviour#636

Open
Shfdis wants to merge 4 commits into
mainfrom
refactor-caching
Open

update caching and ci behaviour#636
Shfdis wants to merge 4 commits into
mainfrom
refactor-caching

Conversation

@Shfdis

@Shfdis Shfdis commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.33%. Comparing base (89c1895) to head (4c31153).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   49.32%   49.33%           
=======================================
  Files         260      260           
  Lines       29656    29656           
=======================================
+ Hits        14628    14630    +2     
+ Misses      15028    15026    -2     
Flag Coverage Δ
sdk 49.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/tests.yaml Outdated
Comment thread scripts/build_cpack_deb_packages.sh
Comment thread .github/workflows/tests.yaml Outdated
Comment thread tests/slo_workloads/Dockerfile.userver
Comment thread .github/workflows/tests.yaml Outdated
@robot-vibe-db

robot-vibe-db Bot commented Jul 2, 2026

Copy link
Copy Markdown

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

  • Minor | Medium: Integration job hardcodes apt dependency list instead of reusing prepare_vm action, creating maintenance drift risk — .github/workflows/tests.yaml:156
  • Minor | Medium: chmod -R a+rwX in the build script grants world-write permissions on host filesystem through docker volume mount — scripts/build_cpack_deb_packages.sh:121
  • Minor | Low: Entire build/ directory tarred as artifact may produce multi-GB uploads and approach GH Actions limits — .github/workflows/tests.yaml:103
  • Nit | High: integration-build job fully duplicates unit job's build, doubling CI build minutes per compiler — .github/workflows/tests.yaml:61-112
  • Nit | Medium: GitHub API JSON parsed with sed regex is fragile; fallback to source build mitigates but adds latency — tests/slo_workloads/Dockerfile.userver:159-161

Additional notes: The PR makes several good improvements: fixing the timestamp-before-use bug in warmup_cache.yaml, migrating from deprecated ::set-output to $GITHUB_OUTPUT, splitting actions/cache into separate cache/restore + cache/save for better control, and extracting the deb build logic into a reusable script. The touch_existing_sources + ccache pattern for incremental builds with cache is well-designed.


This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

@robot-vibe-db

robot-vibe-db Bot commented Jul 2, 2026

Copy link
Copy Markdown

Full analysis log

Analysis performed by claude, claude-opus-4-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants