fix(efcore): generate YDB DELETE ON for ExecuteDelete with joins#667
Open
KirillKurdyukov wants to merge 1 commit into
Open
fix(efcore): generate YDB DELETE ON for ExecuteDelete with joins#667KirillKurdyukov wants to merge 1 commit into
KirillKurdyukov wants to merge 1 commit into
Conversation
Replace unsupported DELETE FROM syntax with YDB DELETE ON, resolving PK columns from table metadata. ExecuteUpdate changes will follow in a separate PR. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
2 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 82.88% 82.34% -0.55%
==========================================
Files 151 151
Lines 9389 9492 +103
Branches 898 913 +15
==========================================
+ Hits 7782 7816 +34
- Misses 1314 1377 +63
- Partials 293 299 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #666 — Delete only.
ExecuteUpdate/UPDATE ONwill follow in a separate PR.Summary
DELETE FROMwith joins with YDBDELETE ONinYdbQuerySqlGenerator.DELETE ONfromTableExpressionmetadata (FindPrimaryKey()), avoiding EF pushdown subqueries.ExecuteDeleteSqlYdbTestand a CHANGELOG entry.Test plan
dotnet test src/EFCore.Ydb/test/EntityFrameworkCore.Ydb.FunctionalTests/EntityFrameworkCore.Ydb.FunctionalTests.csproj --filter FullyQualifiedName~ExecuteDeleteSqlYdbTest -f net10.0Made with Cursor