feat(Cluster): redesign cluster dashboard #2176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
changed the title
artemmufazalov
requested changes
Apr 22, 2025
Comment on lines
+1
to
+6
| { | ||
| "403.title": "Доступ запрещен", | ||
| "403.description": "У вас недостаточно прав для просмотра данной страницы.", | ||
| "responseError.defaultMessage": "Ошибка запроса", | ||
| "error.title": "Ошибка" | ||
| } |
There was a problem hiding this comment.
These keys don't correspond to en keys, please, delete
| [EFlag.Yellow]: 'warning', | ||
| }; | ||
|
|
||
| const EFlagToStatusName: Record<EFlag, string> = { |
There was a problem hiding this comment.
It could be moved to utils so it will be together with EFlagToDescription
| <Disclosure | ||
| arrowPosition="end" | ||
| expanded={expandDashboard} | ||
| onUpdate={() => setExpandDashboard(!expandDashboard)} |
There was a problem hiding this comment.
setExpandDashboard(prev => !prev)
| collapsed, | ||
| ...rest | ||
| }: ClusterMetricsNetworkProps) { | ||
| const [showNetworkUtilization] = useSetting<boolean>(SHOW_NETWORK_UTILIZATION); |
There was a problem hiding this comment.
Why do you need this setting? It is shown only if cluster endpoint supports it (v5)
| <ClusterMetricsCardContent | ||
| status={status} | ||
| fillWidth={fill} | ||
| title={i18n('title_storage')} |
There was a problem hiding this comment.
In collapsed state it is labeled with Storage (title={i18n('title_storage')})
| inverseColorize = false, | ||
| fillWidth, | ||
| }: ClusterMetricsBaseProps & {fillWidth: number}) { | ||
| const normalizedFillWidth = fillWidth < 1 ? 0.5 : fillWidth; |
There was a problem hiding this comment.
Please, explain this code, it looks strange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2128
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔽
Current: 83.35 MB | Main: 83.36 MB
Diff: 0.01 MB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information