Skip to content

Added Isolation concept #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Added Isolation concept #1739

wants to merge 1 commit into from

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the tx label Apr 24, 2025
@asmyasnikov asmyasnikov self-assigned this Apr 24, 2025
Copy link

github.com/ydb-platform/ydb-go-sdk/v3/query

compatible changes

Isolation: added
OnlineRO: added
OnlineROWithInconsistentReads: added
SerializableRW: added
SnapshotRO: added
StaleRO: added

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

Options.TxSettings: changed from *TransactionSettings to *TransactionSettings
Session.BeginTransaction: changed from func(context.Context, *TransactionSettings) (Transaction, error) to func(context.Context, *TransactionSettings) (Transaction, error)
TransactionSettings: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/tx.Settings to github.com/ydb-platform/ydb-go-sdk/v3/internal/tx.Options
TxSettings: changed from func(...TxOption) *TransactionSettings to func(...TxOption) *TransactionSettings
WithTxSettings: changed from func(*TransactionSettings) txSettingsOption to func(*TransactionSettings) txSettingsOption

summary

Base version: v3.108.0 (master)
Cannot suggest a release version.
Incompatible changes were detected.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 22.58065% with 48 lines in your changes missing coverage. Please review.

Project coverage is 70.94%. Comparing base (4ebb2e4) to head (4a76df9).

Files with missing lines Patch % Lines
internal/tx/isolation.go 0.00% 38 Missing ⚠️
internal/tx/settings.go 52.38% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
- Coverage   71.19%   70.94%   -0.25%     
==========================================
  Files         383      384       +1     
  Lines       39140    39194      +54     
==========================================
- Hits        27864    27805      -59     
- Misses      10151    10251     +100     
- Partials     1125     1138      +13     
Flag Coverage Δ
experiment 70.52% <22.58%> (-0.23%) ⬇️
go-1.21.x 70.81% <22.58%> (-0.27%) ⬇️
go-1.24.x 70.93% <22.58%> (-0.21%) ⬇️
integration 53.36% <22.58%> (-0.63%) ⬇️
macOS 38.22% <3.22%> (-0.09%) ⬇️
ubuntu 70.92% <22.58%> (-0.26%) ⬇️
unit 38.25% <3.22%> (-0.07%) ⬇️
windows 38.23% <3.22%> (-0.08%) ⬇️
ydb-24.1 51.07% <22.58%> (-0.59%) ⬇️
ydb-24.2 51.18% <22.58%> (-0.63%) ⬇️
ydb-24.3 51.51% <22.58%> (-0.71%) ⬇️
ydb-24.4 51.64% <22.58%> (-0.60%) ⬇️
ydb-25.1 53.29% <22.58%> (-0.56%) ⬇️
ydb-nightly 70.52% <22.58%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants