Skip to content

Support raw protobuf ydb types #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support raw protobuf ydb types #1787

wants to merge 1 commit into from

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github-actions bot commented May 7, 2025

summary

Base version: v3.108.1 (master)
Suggested version: v3.109.0

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 14.70588% with 29 lines in your changes missing coverage. Please review.

Project coverage is 38.26%. Comparing base (4b3e883) to head (a4ad4da).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/value/cast.go 17.85% 23 Missing ⚠️
internal/bind/params.go 0.00% 4 Missing ⚠️
internal/params/parameters.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4b3e883) and HEAD (a4ad4da). Click for more details.

HEAD has 532 uploads less than BASE
Flag BASE (4b3e883) HEAD (a4ad4da)
unit 54 6
go-1.21.x 72 3
ubuntu 115 2
go-1.24.x 79 3
macOS 18 2
windows 18 2
integration 89 0
ydb-24.4 17 0
ydb-24.1 18 0
ydb-24.3 18 0
ydb-24.2 18 0
ydb-25.1 18 0
experiment 8 0
ydb-nightly 8 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1787       +/-   ##
===========================================
- Coverage   71.20%   38.26%   -32.95%     
===========================================
  Files         383      382        -1     
  Lines       39152    39047      -105     
===========================================
- Hits        27878    14941    -12937     
- Misses      10148    23586    +13438     
+ Partials     1126      520      -606     
Flag Coverage Δ
experiment ?
go-1.21.x 43.26% <14.70%> (-27.83%) ⬇️
go-1.24.x 38.25% <14.70%> (-32.91%) ⬇️
integration ?
macOS 38.25% <14.70%> (-0.05%) ⬇️
ubuntu 38.24% <14.70%> (-32.96%) ⬇️
unit 38.26% <14.70%> (-0.05%) ⬇️
windows 38.23% <14.70%> (-0.07%) ⬇️
ydb-24.1 ?
ydb-24.2 ?
ydb-24.3 ?
ydb-24.4 ?
ydb-25.1 ?
ydb-nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants