best practices in examples #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

asmyasnikov wants to merge 14 commits into master from ctx-err

examples/pagination/cities.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -70,6 +70,10 @@ func selectPaging( @@
     			if !res.NextResultSet(ctx) || !res.HasNextRow() {
     				empty = true
+    				if err := ctx.Err(); err != nil {
+    					return err
+    				}
     				return res.Err()
     			}
     			var addr string
@@ Expand Down @@