feat(balancer): add IPv6-only endpoint filtering#2239
Open
kprokopenko wants to merge 1 commit into
Open
Conversation
github.com/ydb-platform/ydb-go-sdk/v3/balancerscompatible changesIPVersion: added summaryInferred base version: v3.143.0 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2239 +/- ##
==========================================
- Coverage 75.27% 72.25% -3.02%
==========================================
Files 443 443
Lines 45910 46015 +105
==========================================
- Hits 34557 33249 -1308
- Misses 9401 10745 +1344
- Partials 1952 2021 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0c05b56 to
3ef8dc1
Compare
0b99a94 to
50b1819
Compare
50b1819 to
cf48942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
Discovery may return FQDN endpoints without
ip_v6values. In this case gRPC resolves the name itself and can establish a connection over IPv4.Issue Number: N/A
What is the new behavior?
balancers.OnlyIPVersion(..., balancers.IPv6).Other information
Validated with:
go test ./balancers ./internal/discovery ./internal/balancergo test -race -tags integration ./tests/integration -run '^TestOnlyIPVersion$' -count=1golangci-lint run ./...