Skip to content

test(table): expand WaitingQueue coverage for updateLimits, counters, and cold-iterator paths#672

Closed
vasiliy-mikhailov wants to merge 1 commit into
ydb-platform:masterfrom
vasiliy-mikhailov:add-WaitingQueue-tests
Closed

test(table): expand WaitingQueue coverage for updateLimits, counters, and cold-iterator paths#672
vasiliy-mikhailov wants to merge 1 commit into
ydb-platform:masterfrom
vasiliy-mikhailov:add-WaitingQueue-tests

Conversation

@vasiliy-mikhailov

Copy link
Copy Markdown

Adds 11 unit tests to WaitingQueueTest exercising updateLimits (single-arg factor, waiting-acquire triggering, shrink-driven overflow destroy), the getUsedCount/getPendingCount stat accessors, idle-object clearing on close, and the pre-completed-future idle-poll fallback. All tests reuse the file's existing JUnit 4 helper harness and assert real pool state transitions.

metric before after
mutation score 81% 88%
test methods added n/a 11

The additions are append-only (no existing test is modified) and pass against the current code.


How this was produced

This PR was generated with an AI-assisted pipeline built around mutation testing (PIT). The pipeline mutates the target class (flipping conditions and changing boundary/edge cases) and runs the existing tests against each mutant. Where a mutant survives (the existing tests do not catch that edge case), it writes a focused test for that case and reruns PIT to confirm the new test actually kills that specific mutant. So every added test is verified to catch a concrete edge case the suite missed before, rather than being speculative or redundant. The change is additive only (no production code modified), and the module builds green under its CI JDK.

@codecov-commenter

codecov-commenter commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (3183f3e) to head (41a1b53).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #672   +/-   ##
=========================================
  Coverage     71.72%   71.72%           
- Complexity     3431     3432    +1     
=========================================
  Files           386      386           
  Lines         16072    16072           
  Branches       1689     1689           
=========================================
  Hits          11528    11528           
+ Misses         3895     3893    -2     
- Partials        649      651    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268

alex268 commented Jul 3, 2026

Copy link
Copy Markdown
Member

I checked this code, and the only improvement was in these two lines. Those lines had a minor mistake, so I fixed it in a separate PR.

Other than that, there are no improvements here, so I’m closing this PR.

@alex268 alex268 closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants