Skip to content

Release node name on graceful shutdown (Issue #9734) #10367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Nov 29, 2024
Merged

Release node name on graceful shutdown (Issue #9734) #10367

merged 28 commits into from
Nov 29, 2024

Conversation

stanislav-shchetinin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Improvement

Additional information

...

@stanislav-shchetinin stanislav-shchetinin marked this pull request as draft October 13, 2024 14:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

⚪ 2024-10-13 14:22:46 UTC Pre-commit check linux-x86_64-release-asan for c52d226 has started.
⚪ 2024-10-13 14:23:15 UTC Artifacts will be uploaded here
⚪ 2024-10-13 14:26:25 UTC ya make is running...
🔴 2024-10-13 14:33:37 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

⚪ 2024-10-13 14:24:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for c52d226 has started.
⚪ 2024-10-13 14:24:14 UTC Artifacts will be uploaded here
⚪ 2024-10-13 14:27:40 UTC ya make is running...
🔴 2024-10-13 14:33:50 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

⚪ 2024-10-13 16:13:48 UTC Pre-commit check linux-x86_64-release-asan for 0286ccb has started.
⚪ 2024-10-13 16:14:00 UTC Artifacts will be uploaded here
⚪ 2024-10-13 16:17:24 UTC ya make is running...
⚫ 2024-10-13 16:22:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

⚪ 2024-10-13 16:16:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0286ccb has started.
⚪ 2024-10-13 16:16:35 UTC Artifacts will be uploaded here
⚪ 2024-10-13 16:19:56 UTC ya make is running...
⚫ 2024-10-13 16:22:49 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

⚪ 2024-10-13 16:26:47 UTC Pre-commit check linux-x86_64-release-asan for ed2f8c0 has started.
⚪ 2024-10-13 16:26:57 UTC Artifacts will be uploaded here
⚪ 2024-10-13 16:30:16 UTC ya make is running...
🟡 2024-10-13 18:29:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11790 11545 0 74 58 113

🟢 2024-10-13 18:30:55 UTC Build successful.
🟡 2024-10-13 18:31:31 UTC ydbd size 5.7 GiB changed* by +461.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ec35b6a merge: ed2f8c0 diff diff %
ydbd size 6 095 885 056 Bytes 6 096 357 696 Bytes +461.6 KiB +0.008%
ydbd stripped size 1 520 278 032 Bytes 1 520 361 296 Bytes +81.3 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

⚪ 2024-10-13 16:26:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for ed2f8c0 has started.
⚪ 2024-10-13 16:27:03 UTC Artifacts will be uploaded here
⚪ 2024-10-13 16:30:22 UTC ya make is running...
🟡 2024-10-13 17:56:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41531 35944 0 4 5474 109

⚪ 2024-10-13 17:59:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-13 18:11:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 12 0 0 1 100

🟢 2024-10-13 18:11:10 UTC Build successful.
🟡 2024-10-13 18:11:36 UTC ydbd size 2.8 GiB changed* by +222.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ec35b6a merge: ed2f8c0 diff diff %
ydbd size 3 009 096 464 Bytes 3 009 324 048 Bytes +222.2 KiB +0.008%
ydbd stripped size 477 346 872 Bytes 477 364 888 Bytes +17.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 08:43:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 09ae5b9 has started.
⚪ 2024-10-14 08:43:17 UTC Artifacts will be uploaded here
⚪ 2024-10-14 08:46:28 UTC ya make is running...
⚫ 2024-10-14 09:02:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 08:43:25 UTC Pre-commit check linux-x86_64-release-asan for 09ae5b9 has started.
⚪ 2024-10-14 08:43:35 UTC Artifacts will be uploaded here
⚪ 2024-10-14 08:46:46 UTC ya make is running...
⚫ 2024-10-14 09:02:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 09:04:07 UTC Pre-commit check linux-x86_64-release-asan for 268dd62 has started.
⚪ 2024-10-14 09:04:20 UTC Artifacts will be uploaded here
⚪ 2024-10-14 09:07:31 UTC ya make is running...
🟡 2024-10-14 10:44:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11785 11573 0 56 47 109

🟢 2024-10-14 10:45:38 UTC Build successful.
🟡 2024-10-14 10:46:12 UTC ydbd size 5.7 GiB changed* by +457.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1985ffc merge: 268dd62 diff diff %
ydbd size 6 095 927 984 Bytes 6 096 396 832 Bytes +457.9 KiB +0.008%
ydbd stripped size 1 520 281 456 Bytes 1 520 360 944 Bytes +77.6 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 09:04:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 268dd62 has started.
⚪ 2024-10-14 09:04:26 UTC Artifacts will be uploaded here
⚪ 2024-10-14 09:07:44 UTC ya make is running...
🟡 2024-10-14 10:20:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41535 35951 0 1 5471 112

⚪ 2024-10-14 10:24:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 10:35:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 11 0 0 0 100

🟢 2024-10-14 10:35:53 UTC Build successful.
🟡 2024-10-14 10:36:12 UTC ydbd size 2.8 GiB changed* by +222.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1985ffc merge: 268dd62 diff diff %
ydbd size 3 009 100 264 Bytes 3 009 327 880 Bytes +222.3 KiB +0.008%
ydbd stripped size 477 343 160 Bytes 477 361 176 Bytes +17.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested review from pixcc and CyberROFL October 14, 2024 09:05
CyberROFL
CyberROFL reviewed Oct 14, 2024
View reviewed changes
pixcc
pixcc reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@pixcc pixcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь, пожалуйста, какой-нибудь тестик в node_broker_ut.cpp, в котором будут посылаться DecomissionRequest в NodeBroker и проверяться логика обработки этого сообщения.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 22:03:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for c742aa5 has started.
⚪ 2024-10-14 22:04:09 UTC Artifacts will be uploaded here
⚪ 2024-10-14 22:07:36 UTC ya make is running...
🟡 2024-10-14 23:36:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41562 35963 0 17 5472 110

⚪ 2024-10-14 23:39:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 23:51:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
124 (only retried tests) 23 0 0 0 101

🟢 2024-10-14 23:51:26 UTC Build successful.
🟡 2024-10-14 23:51:45 UTC ydbd size 2.8 GiB changed* by +246.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6e67eb5 merge: c742aa5 diff diff %
ydbd size 3 010 987 104 Bytes 3 011 239 768 Bytes +246.7 KiB +0.008%
ydbd stripped size 477 510 168 Bytes 477 534 584 Bytes +23.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 22:04:13 UTC Pre-commit check linux-x86_64-release-asan for c742aa5 has started.
⚪ 2024-10-14 22:04:23 UTC Artifacts will be uploaded here
⚪ 2024-10-14 22:07:47 UTC ya make is running...
🟡 2024-10-15 00:05:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11816 11558 0 97 57 104

🟢 2024-10-15 00:06:39 UTC Build successful.
🟡 2024-10-15 00:07:13 UTC ydbd size 5.7 GiB changed* by +493.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6e67eb5 merge: c742aa5 diff diff %
ydbd size 6 099 992 680 Bytes 6 100 498 128 Bytes +493.6 KiB +0.008%
ydbd stripped size 1 520 943 056 Bytes 1 521 028 176 Bytes +83.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc linked an issue Nov 20, 2024 that may be closed by this pull request
Release node name on graceful shutdown #9734
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 15:45:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for afc72f8 has started.
⚪ 2024-11-27 15:45:54 UTC Artifacts will be uploaded here
⚪ 2024-11-27 15:49:21 UTC ya make is running...
🟡 2024-11-27 17:21:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32595 29753 0 8 2720 114

⚪ 2024-11-27 17:24:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-27 17:42:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
722 (only retried tests) 615 0 0 0 107

🟢 2024-11-27 17:42:11 UTC Build successful.
🟡 2024-11-27 17:42:35 UTC ydbd size 2.5 GiB changed* by +210.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 721ecf3 merge: afc72f8 diff diff %
ydbd size 2 694 493 408 Bytes 2 694 708 888 Bytes +210.4 KiB +0.008%
ydbd stripped size 482 141 424 Bytes 482 160 304 Bytes +18.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 15:45:48 UTC Pre-commit check linux-x86_64-release-asan for afc72f8 has started.
⚪ 2024-11-27 15:46:01 UTC Artifacts will be uploaded here
⚪ 2024-11-27 15:49:25 UTC ya make is running...
🟡 2024-11-27 17:41:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15175 15091 0 26 10 48

🟢 2024-11-27 17:43:22 UTC Build successful.
🟡 2024-11-27 17:43:51 UTC ydbd size 4.9 GiB changed* by +384.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 721ecf3 merge: afc72f8 diff diff %
ydbd size 5 293 890 408 Bytes 5 294 284 552 Bytes +384.9 KiB +0.007%
ydbd stripped size 1 360 935 568 Bytes 1 361 005 744 Bytes +68.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 06:18:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for ba89b7e has started.
⚪ 2024-11-28 06:18:14 UTC Artifacts will be uploaded here
⚪ 2024-11-28 06:21:39 UTC ya make is running...
🔴 2024-11-28 06:30:48 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 06:20:33 UTC Pre-commit check linux-x86_64-release-asan for ba89b7e has started.
⚪ 2024-11-28 06:20:45 UTC Artifacts will be uploaded here
⚪ 2024-11-28 06:24:03 UTC ya make is running...
🔴 2024-11-28 06:31:06 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 06:44:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa199e3 has started.
⚪ 2024-11-28 06:44:24 UTC Artifacts will be uploaded here
⚪ 2024-11-28 06:47:40 UTC ya make is running...
🔴 2024-11-28 06:51:34 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 06:45:19 UTC Pre-commit check linux-x86_64-release-asan for fa199e3 has started.
⚪ 2024-11-28 06:45:32 UTC Artifacts will be uploaded here
⚪ 2024-11-28 06:49:03 UTC ya make is running...
🔴 2024-11-28 06:57:39 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 07:03:08 UTC Pre-commit check linux-x86_64-release-asan for 3b6d060 has started.
⚪ 2024-11-28 07:03:21 UTC Artifacts will be uploaded here
⚪ 2024-11-28 07:06:38 UTC ya make is running...
🔴 2024-11-28 07:13:56 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 07:06:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3b6d060 has started.
⚪ 2024-11-28 07:06:11 UTC Artifacts will be uploaded here
⚪ 2024-11-28 07:09:27 UTC ya make is running...
🔴 2024-11-28 07:23:58 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 10:46:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for dbccd5c has started.
⚪ 2024-11-28 10:47:07 UTC Artifacts will be uploaded here
⚪ 2024-11-28 10:50:37 UTC ya make is running...
🟡 2024-11-28 12:22:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32601 29768 0 1 2719 113

⚪ 2024-11-28 12:25:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 12:36:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
741 (only retried tests) 632 0 0 0 109

🟢 2024-11-28 12:37:13 UTC Build successful.
🟡 2024-11-28 12:37:34 UTC ydbd size 2.5 GiB changed* by +216.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7680faa merge: dbccd5c diff diff %
ydbd size 2 695 024 168 Bytes 2 695 245 368 Bytes +216.0 KiB +0.008%
ydbd stripped size 482 194 416 Bytes 482 214 256 Bytes +19.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 10:46:57 UTC Pre-commit check linux-x86_64-release-asan for dbccd5c has started.
⚪ 2024-11-28 10:47:09 UTC Artifacts will be uploaded here
⚪ 2024-11-28 10:50:41 UTC ya make is running...
🟡 2024-11-28 12:32:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15180 15106 0 16 6 52

🟢 2024-11-28 12:33:42 UTC Build successful.
🟡 2024-11-28 12:34:12 UTC ydbd size 4.9 GiB changed* by +394.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7680faa merge: dbccd5c diff diff %
ydbd size 5 294 877 128 Bytes 5 295 280 680 Bytes +394.1 KiB +0.008%
ydbd stripped size 1 361 163 312 Bytes 1 361 231 760 Bytes +66.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

pixcc
pixcc requested changes Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 16:51:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc00764 has started.
⚪ 2024-11-28 16:51:50 UTC Artifacts will be uploaded here
⚪ 2024-11-28 16:55:48 UTC ya make is running...
🟢 2024-11-28 18:24:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32611 29779 0 0 2718 114

🟢 2024-11-28 18:27:10 UTC Build successful.
🟡 2024-11-28 18:27:28 UTC ydbd size 2.5 GiB changed* by +214.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2f89980 merge: cc00764 diff diff %
ydbd size 2 686 661 376 Bytes 2 686 880 672 Bytes +214.2 KiB +0.008%
ydbd stripped size 482 255 888 Bytes 482 279 568 Bytes +23.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⚪ 2024-11-28 16:53:02 UTC Pre-commit check linux-x86_64-release-asan for cc00764 has started.
⚪ 2024-11-28 16:53:14 UTC Artifacts will be uploaded here
⚪ 2024-11-28 16:56:29 UTC ya make is running...
🟡 2024-11-28 18:25:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15190 15127 0 9 7 47

🟢 2024-11-28 18:27:02 UTC Build successful.
🟡 2024-11-28 18:27:29 UTC ydbd size 4.9 GiB changed* by +382.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2f89980 merge: cc00764 diff diff %
ydbd size 5 281 015 488 Bytes 5 281 406 664 Bytes +382.0 KiB +0.007%
ydbd stripped size 1 361 303 664 Bytes 1 361 371 088 Bytes +65.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@stanislav-shchetinin stanislav-shchetinin merged commit f7b8420 into ydb-platform:main Nov 29, 2024
10 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
@naspirato naspirato mentioned this pull request Dec 1, 2024
Open
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@pixcc pixcc pixcc approved these changes

Assignees

@stanislav-shchetinin stanislav-shchetinin

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release node name on graceful shutdown
3 participants
@stanislav-shchetinin @pixcc @CyberROFL