Skip to content

YQ-3949 fix pq source sensors names #13088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

YQ-3949 fix pq source sensors names #13088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ydb/library/yql/providers/pq/async_io/dq_pq_rd_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ struct TRowDispatcherReadActorMetrics {
explicit TRowDispatcherReadActorMetrics(const TTxId& txId, ui64 taskId, const ::NMonitoring::TDynamicCounterPtr& counters)
: TxId(std::visit([](auto arg) { return ToString(arg); }, txId))
, Counters(counters) {
SubGroup = Counters->GetSubgroup("sink", "RdPqRead");
auto sink = SubGroup->GetSubgroup("tx_id", TxId);
auto task = sink->GetSubgroup("task_id", ToString(taskId));
SubGroup = Counters->GetSubgroup("source", "RdPqRead");
auto source = SubGroup->GetSubgroup("tx_id", TxId);
auto task = source->GetSubgroup("task_id", ToString(taskId));
InFlyGetNextBatch = task->GetCounter("InFlyGetNextBatch");
InFlyAsyncInputData = task->GetCounter("InFlyAsyncInputData");
}
Expand Down
8 changes: 4 additions & 4 deletions ydb/library/yql/providers/pq/async_io/dq_pq_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ class TDqPqReadActor : public NActors::TActor<TDqPqReadActor>, public NYql::NDq:
TMetrics(const TTxId& txId, ui64 taskId, const ::NMonitoring::TDynamicCounterPtr& counters)
: TxId(std::visit([](auto arg) { return ToString(arg); }, txId))
, Counters(counters) {
SubGroup = Counters->GetSubgroup("sink", "PqRead");
auto sink = SubGroup->GetSubgroup("tx_id", TxId);
auto task = sink->GetSubgroup("task_id", ToString(taskId));
SubGroup = Counters->GetSubgroup("source", "PqRead");
auto source = SubGroup->GetSubgroup("tx_id", TxId);
auto task = source->GetSubgroup("task_id", ToString(taskId));
InFlyAsyncInputData = task->GetCounter("InFlyAsyncInputData");
InFlySubscribe = task->GetCounter("InFlySubscribe");
AsyncInputDataRate = task->GetCounter("AsyncInputDataRate", true);
ReconnectRate = task->GetCounter("ReconnectRate", true);
DataRate = task->GetCounter("DataRate", true);
WaitEventTimeMs = sink->GetHistogram("WaitEventTimeMs", NMonitoring::ExponentialHistogram(13, 2, 1)); // ~ 1ms -> ~ 8s
WaitEventTimeMs = source->GetHistogram("WaitEventTimeMs", NMonitoring::ExponentialHistogram(13, 2, 1)); // ~ 1ms -> ~ 8s
}

~TMetrics() {
Expand Down
Loading