Skip to content

refactor 'ydb scheme rmdir' implementation #16232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Mar 25, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

refactoring + tests

Also fixed some bugs:

  • We attempted deleting the subdomain if the --path . was specified, so the ydb scheme rmdir would always result in an error previously in this case.
  • We haven't ordered the deletions of external data sources and external tables (the former must be deleted after the latter). It could have led to an error in ydb scheme rmdir if it got to the external data source first.
  • Straight (non-reverse) order of scheme objects to remove on cleanup on failed restore. This prevented deletion of directories. We have received errors always in this case.

+ deduplicated code by using the generic RemovePathRecursive on cleanup after a failed restore

Copy link

github-actions bot commented Mar 25, 2025

🟢 2025-03-26 13:36:58 UTC The validation of the Pull Request description is successful.

@jepett0 jepett0 force-pushed the RMDIR.refactoring.1 branch from 9f53297 to 3e84d1e Compare March 25, 2025 17:54

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 changed the title RMDIR.refactoring.1 refactor 'ydb scheme rmdir' implementation Mar 26, 2025
@jepett0 jepett0 marked this pull request as ready for review March 26, 2025 13:19
@jepett0 jepett0 requested a review from a team as a code owner March 26, 2025 13:19
@jepett0 jepett0 requested a review from CyberROFL March 26, 2025 13:19
@jepett0 jepett0 linked an issue Mar 26, 2025 that may be closed by this pull request
@jepett0 jepett0 requested a review from CyberROFL March 26, 2025 16:42

This comment was marked as outdated.

This comment was marked as outdated.

CyberROFL
CyberROFL previously approved these changes Mar 26, 2025

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 requested a review from CyberROFL March 28, 2025 09:10
pnv1
pnv1 previously approved these changes Mar 28, 2025
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Mar 28, 2025

2025-03-28 10:58:05 UTC Pre-commit check linux-x86_64-release-asan for 13af832 has started.
2025-03-28 10:58:09 UTC Artifacts will be uploaded here
2025-03-28 11:00:52 UTC ya make is running...
🟡 2025-03-28 12:15:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12430 12276 0 111 8 35

2025-03-28 12:17:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 12:35:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
213 (only retried tests) 147 0 33 4 29

2025-03-28 12:35:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-28 12:48:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
93 (only retried tests) 32 0 32 4 25

🟢 2025-03-28 12:49:05 UTC Build successful.
🟢 2025-03-28 12:49:41 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9fb5600 merge: 13af832 diff diff %
ydbd size 4 119 149 616 Bytes 4 119 149 520 Bytes -96 Bytes -0.000%
ydbd stripped size 1 423 819 368 Bytes 1 423 819 304 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 28, 2025

2025-03-28 10:58:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13af832 has started.
2025-03-28 10:58:39 UTC Artifacts will be uploaded here
2025-03-28 11:01:36 UTC ya make is running...
🟡 2025-03-28 12:09:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26841 24187 0 2 2540 112

2025-03-28 12:11:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-28 12:32:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
152 (only retried tests) 52 0 0 0 100

🟢 2025-03-28 12:32:14 UTC Build successful.
🟢 2025-03-28 12:32:34 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9fb5600 merge: 13af832 diff diff %
ydbd size 2 347 157 296 Bytes 2 347 157 296 Bytes 0 Bytes 0.000%
ydbd stripped size 490 811 520 Bytes 490 811 520 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 merged commit dae8c90 into ydb-platform:main Mar 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants