Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late messages TEvProposeTransaction (#16216) #16270

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

Move changes from PR #16216

The PQ tablet can receive the message TEvPersQueue::TEvProposeTransaction twice from the SS. For example, when there are delays in the operation of the IC. As a result, the Drop Tablet operation may hang in the PQ tablet.

#16218

Changelog category

  • Bugfix

Description for reviewers

The PQ tablet allows the DropTablet operation only if it has an empty list of transactions, or there is a configuration transaction without a PlanStep.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner March 26, 2025 11:37
@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) March 26, 2025 11:37
Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 11:39:39 UTC Pre-commit check for 2f7fb28 has started.
2025-03-26 11:42:27 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-26 12:07:15 UTC Build successful.
2025-03-26 12:07:32 UTC Tests are running...
🔴 2025-03-26 14:20:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10366 10260 0 33 29 44

🟢 2025-03-26 14:21:45 UTC ydbd size 5.6 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 07e7130 merge: 2f7fb28 diff diff %
ydbd size 6 027 596 904 Bytes 6 027 598 200 Bytes +1.3 KiB +0.000%
ydbd stripped size 1 508 432 480 Bytes 1 508 433 312 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 11:40:38 UTC Pre-commit check for 2f7fb28 has started.
2025-03-26 11:43:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-26 12:23:29 UTC Build successful.
2025-03-26 12:23:47 UTC Tests are running...
🔴 2025-03-26 13:52:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14803 13438 0 19 1302 44

🟢 2025-03-26 13:53:10 UTC ydbd size 8.3 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 07e7130 merge: 2f7fb28 diff diff %
ydbd size 8 898 201 592 Bytes 8 898 204 256 Bytes +2.6 KiB +0.000%
ydbd stripped size 485 015 464 Bytes 485 015 720 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 92655ab into ydb-platform:stable-24-4 Mar 26, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants