Skip to content

Library import 250425-1915 #17754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 26, 2025
Merged

Library import 250425-1915 #17754

merged 22 commits into from
Apr 26, 2025

Conversation

alexv-smirnov
Copy link
Member

PR was created by rightlib sync workflow run

robot-piglet and others added 22 commits April 25, 2025 11:07
commit_hash:9feae42eea92837e800e65cbcf9acc15f580e438
commit_hash:5065ec89aed827ce2d112d5f8623dfb0215a5207
…ee_parse function

### Changelog entry

...

### Changelog category

* Bugfix

### Description for reviewers

This PR fixes a security vulnerability in yajl\_tree\_parse() that was cloned from yaml but did not receive the security patch. The original issue was reported and fixed under [likema/yajl@31531a6](likema/yajl@31531a6).
This PR applies the same patch to eliminate the vulnerability.

References
[GHSA-cqgm-m7h3-xgwm](GHSA-cqgm-m7h3-xgwm "GHSA-cqgm-m7h3-xgwm")
<https://nvd.nist.gov/vuln/detail/CVE-2023-33460>
[likema/yajl@31531a6](likema/yajl@31531a6)

---

Pull Request resolved: <#17570>
commit_hash:d022109c9836673d185db1ffab7e1064ab8f561d
commit_hash:a2ae9e9ddb0ebd0f3ce876aa1f8f29e291d3aed1
commit_hash:99750816a334658ecd2f306d4a496865e7fcc4d8
commit_hash:5f4bdb090c2f60459073e3e95ccd39ec58b95232
commit_hash:4149625a81c51af40642fe498a887608cc57305f
* Changelog entry
   Type: fix
   Component: misc-server
Tablet nodes used to not validate erasure coding. This is now fixed.
commit_hash:c87b15794e5b904cf5876e3887af9aed62b650bc
commit_hash:2e0d520af978a9a16495ac4fd2adc8f072ed973a
* Changelog entry

Type: feature

Component: controller-agent

Add new delivery fenced connection that works on vanilla linux kernel. It may be used for cpu intensive or gpu jobs to prevent job abort on interruption.
commit_hash:02e0f41ad907dfe1c11defc5439214e31ea12ad5
commit_hash:4d256df3cba483ed480b07058d40dc2771082b86
commit_hash:662bf10e4c8caa4c7310317eacd39715dbadc691
- [x] Chained futures, add `CompleteAsync` method (then will migrate the YDB CLI on it).
- [x] Removed deadlined and fallback NameService as unused
- [x] Annotate thread-safe methods with `const` and use `AtomicSharedPtr` for them.
- [x] Move `name` to `name/service` with backward compatibility with the YDB CLI.

---

`CompletionEngine` is left thread-unsafe because of the dependency chain `CompletionEngine -> LocalSyntaxAnalysis -> C3Engine` which is thread-unsafe, but readonly indexed data structures such as `Ranking` and `NameService` are annotated with const and distributed via shared pointers.

I removed deadlined and fallback name services because the first is stupid the second is ahead of its time and is better to be added later to keep interfaces as minimal as possible.

---

The migration on async complete plan:
1. Introduce CompleteAsync
2. Migrate clients on CompleteAsync
3. Make Complete to return Future
4. Migrate clients on Complete
5. Remove CompleteAsync

---

- Related to #9056
- Related to vityaman#33
- Related to vityaman#31

---

Pull Request resolved: ytsaurus/ytsaurus#1241

Co-authored-by: vvvv <[email protected]>
Co-authored-by: vvvv <[email protected]>
commit_hash:497cc081ab78bebf7354e0acfaa418d936cc8240
commit_hash:14cd0f852fd43d48ad01a7f6608504ef16a4ac95
commit_hash:39c670927995d2e5558f218e3d198f29a2e2af40
commit_hash:8ca44c4f80502be7e9c4c970f05b64ad9b50b13f
commit_hash:22417d8bf75459bf61b1bfd340a56af7028785c4
commit_hash:479beaff03a33251903e09d1196e18e030d4029c
commit_hash:c94956365009858d19389e25868603490967a181
commit_hash:7e61a1191c39017d06254e045d3f58bbbbdadc01
@alexv-smirnov alexv-smirnov requested a review from a team as a code owner April 25, 2025 19:17
Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:18:43 UTC Pre-commit check linux-x86_64-release-asan for 1bd4377 has started.
2025-04-25 19:19:06 UTC Artifacts will be uploaded here
2025-04-25 19:24:54 UTC ya make is running...
🟡 2025-04-25 21:39:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16431 16311 0 62 34 24

2025-04-25 21:40:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-25 22:06:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
725 (only retried tests) 632 0 45 26 22

2025-04-25 22:07:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-25 22:32:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
659 (only retried tests) 557 0 44 36 22

🟢 2025-04-25 22:32:44 UTC Build successful.
🟡 2025-04-25 22:33:18 UTC ydbd size 3.8 GiB changed* by +382.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 065dd6e merge: 1bd4377 diff diff %
ydbd size 4 120 274 248 Bytes 4 120 665 400 Bytes +382.0 KiB +0.009%
ydbd stripped size 1 428 517 272 Bytes 1 428 691 272 Bytes +169.9 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:19:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1bd4377 has started.
2025-04-25 19:20:16 UTC Artifacts will be uploaded here
2025-04-25 19:26:12 UTC ya make is running...
🟡 2025-04-25 21:49:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31349 28647 0 7 2650 45

2025-04-25 21:52:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-25 22:27:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
529 (only retried tests) 480 0 2 12 35

2025-04-25 22:27:45 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-25 23:02:17 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 88 0 1 6 36

🟢 2025-04-25 23:02:24 UTC Build successful.
🟡 2025-04-25 23:02:47 UTC ydbd size 2.2 GiB changed* by +107.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 065dd6e merge: 1bd4377 diff diff %
ydbd size 2 342 188 048 Bytes 2 342 297 920 Bytes +107.3 KiB +0.005%
ydbd stripped size 492 592 192 Bytes 492 614 024 Bytes +21.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-04-25 19:21:01 UTC The validation of the Pull Request description is successful.

@alexv-smirnov
Copy link
Member Author

Check checks_integrated failed. All future check are suspended, please remove the rightlib-fail label to enable checks. Rightlib sync workflow logs can be found here.

Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 23:34:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for a23354a has started.
2025-04-25 23:34:13 UTC Artifacts will be uploaded here
2025-04-25 23:39:39 UTC ya make is running...
🟡 2025-04-26 01:27:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31349 28660 0 3 2644 42

2025-04-26 01:29:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-26 01:53:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 96 0 1 12 33

2025-04-26 01:53:37 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-26 02:27:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 93 0 0 1 34

🟢 2025-04-26 02:27:48 UTC Build successful.
🟡 2025-04-26 02:28:11 UTC ydbd size 2.2 GiB changed* by +107.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 290386c merge: a23354a diff diff %
ydbd size 2 342 188 048 Bytes 2 342 297 920 Bytes +107.3 KiB +0.005%
ydbd stripped size 492 592 192 Bytes 492 614 024 Bytes +21.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 23:36:22 UTC Pre-commit check linux-x86_64-release-asan for a23354a has started.
2025-04-25 23:36:37 UTC Artifacts will be uploaded here
2025-04-25 23:41:57 UTC ya make is running...
🟡 2025-04-26 01:37:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16431 16282 0 84 41 24

2025-04-26 01:39:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-26 02:09:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
949 (only retried tests) 842 0 50 31 26

2025-04-26 02:10:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-26 02:34:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
770 (only retried tests) 665 0 48 32 25

🟢 2025-04-26 02:34:43 UTC Build successful.
🟡 2025-04-26 02:35:17 UTC ydbd size 3.8 GiB changed* by +382.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 290386c merge: a23354a diff diff %
ydbd size 4 120 274 248 Bytes 4 120 665 400 Bytes +382.0 KiB +0.009%
ydbd stripped size 1 428 517 272 Bytes 1 428 691 272 Bytes +169.9 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexv-smirnov alexv-smirnov merged commit 8f6d662 into main Apr 26, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants