Skip to content

24-4-4: Limit inflight config updates #17755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Apr 25, 2025

Changelog entry

Limit internal inflight config updates.

Changelog category

  • Performance improvement

Description for reviewers

#17725

@CyberROFL CyberROFL requested a review from a team as a code owner April 25, 2025 19:27
@CyberROFL CyberROFL assigned CyberROFL and unassigned CyberROFL Apr 25, 2025
@CyberROFL CyberROFL linked an issue Apr 25, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:30:35 UTC Pre-commit check for 3773308 has started.
2025-04-25 19:33:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-04-25 20:13:03 UTC Build successful.
2025-04-25 20:13:22 UTC Tests are running...
🔴 2025-04-25 21:38:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14640 13282 0 21 1300 37

🟡 2025-04-25 21:40:49 UTC ydbd size 8.3 GiB changed* by +184.9 KiB, which is >= 100.0 KiB vs stable-24-4-4-hotfix: Warning

ydbd size dash stable-24-4-4-hotfix: 171b7a4 merge: 3773308 diff diff %
ydbd size 8 898 973 304 Bytes 8 899 162 624 Bytes +184.9 KiB +0.002%
ydbd stripped size 485 034 184 Bytes 485 046 344 Bytes +11.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:32:48 UTC Pre-commit check for 3773308 has started.
2025-04-25 19:35:54 UTC Build linux-x86_64-release-asan is running...
🟢 2025-04-25 19:58:41 UTC Build successful.
2025-04-25 19:58:57 UTC Tests are running...
🔴 2025-04-25 22:19:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10393 10285 0 39 25 44

🟡 2025-04-25 22:20:07 UTC ydbd size 5.6 GiB changed* by +111.1 KiB, which is >= 100.0 KiB vs stable-24-4-4-hotfix: Warning

ydbd size dash stable-24-4-4-hotfix: 171b7a4 merge: 3773308 diff diff %
ydbd size 6 028 182 024 Bytes 6 028 295 792 Bytes +111.1 KiB +0.002%
ydbd stripped size 1 508 527 136 Bytes 1 508 553 664 Bytes +25.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit 9c466b2 into ydb-platform:stable-24-4-4-hotfix Apr 27, 2025
6 of 10 checks passed
@CyberROFL CyberROFL deleted the limit-inflight-config-updates-24-4-4-hotfix branch April 27, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProvider: limit inflight config updates
2 participants