Skip to content

25-1: Limit inflight config updates #17756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Apr 25, 2025

Changelog entry

Limit internal inflight config updates.

Changelog category

  • Performance improvement

Description for reviewers

#17725

@CyberROFL CyberROFL requested a review from a team as a code owner April 25, 2025 19:28
@CyberROFL CyberROFL self-assigned this Apr 25, 2025
Copy link

github-actions bot commented Apr 25, 2025

🟢 2025-04-25 19:30:07 UTC The validation of the Pull Request description is successful.

@CyberROFL CyberROFL removed their assignment Apr 25, 2025
@CyberROFL CyberROFL linked an issue Apr 25, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:30:42 UTC Pre-commit check linux-x86_64-release-asan for afb38e6 has started.
2025-04-25 19:30:58 UTC Artifacts will be uploaded here
2025-04-25 19:33:48 UTC ya make is running...
🟡 2025-04-25 20:44:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12004 11875 0 30 64 35

2025-04-25 20:46:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-25 21:06:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 89 0 6 40 32

2025-04-25 21:07:00 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-25 21:26:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 31 0 6 35 32

🟢 2025-04-25 21:26:42 UTC Build successful.
🟢 2025-04-25 21:27:07 UTC ydbd size 3.6 GiB changed* by +63.3 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 5c70e5f merge: afb38e6 diff diff %
ydbd size 3 905 235 200 Bytes 3 905 300 048 Bytes +63.3 KiB +0.002%
ydbd stripped size 1 366 366 224 Bytes 1 366 388 400 Bytes +21.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:32:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for afb38e6 has started.
2025-04-25 19:32:19 UTC Artifacts will be uploaded here
2025-04-25 19:35:16 UTC ya make is running...
🟡 2025-04-25 20:36:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18818 17550 0 1 1206 61

2025-04-25 20:38:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-25 20:58:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 59 0 0 0 59

🟢 2025-04-25 20:58:56 UTC Build successful.
🟢 2025-04-25 20:59:16 UTC ydbd size 2.1 GiB changed* by +39.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 5c70e5f merge: afb38e6 diff diff %
ydbd size 2 245 003 280 Bytes 2 245 043 352 Bytes +39.1 KiB +0.002%
ydbd stripped size 475 327 480 Bytes 475 335 544 Bytes +7.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) April 25, 2025 19:32
@CyberROFL CyberROFL merged commit 0c4f5a4 into ydb-platform:stable-25-1 Apr 27, 2025
14 checks passed
@CyberROFL CyberROFL deleted the limit-inflight-config-updates-25-1 branch April 27, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProvider: limit inflight config updates
2 participants