Support partition policy for Index Table in SHOW CREATE TABLE #17759

shnikd · 2025-04-26T00:54:22Z

Changelog category

Not for changelog (changelog entry is not required)

Description for reviewers

Support sequences in SHOW CREATE TABLE

github-actions · 2025-04-26T01:01:00Z

🟢 2025-04-26 01:01:13 UTC The validation of the Pull Request description is successful.

github-actions · 2025-04-26T01:32:54Z

⚪ 2025-04-26 01:32:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 994e72d has started.
⚪ 2025-04-26 01:33:17 UTC Artifacts will be uploaded here
⚪ 2025-04-26 01:36:29 UTC ya make is running...
🟡 2025-04-26 02:42:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20441	19055	0	4	1346	36

⚪ 2025-04-26 02:43:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-26 02:56:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
127 (only retried tests)	84	0	0	14	29

🟢 2025-04-26 02:56:28 UTC Build successful.
🟢 2025-04-26 02:56:46 UTC ydbd size 2.2 GiB changed* by +9.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `290386c`	merge: `994e72d`	diff	diff %
ydbd size	2 342 188 048 Bytes	2 342 197 336 Bytes	+9.1 KiB	+0.000%
ydbd stripped size	492 592 192 Bytes	492 593 920 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-26T02:23:47Z

⚪ 2025-04-26 02:23:47 UTC Pre-commit check linux-x86_64-release-asan for 994e72d has started.
⚪ 2025-04-26 02:23:54 UTC Artifacts will be uploaded here
⚪ 2025-04-26 02:26:36 UTC ya make is running...
🟡 2025-04-26 03:49:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12690	12527	0	108	31	24

⚪ 2025-04-26 03:50:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-26 04:19:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1048 (only retried tests)	944	0	47	34	23

⚪ 2025-04-26 04:19:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-26 04:51:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
826 (only retried tests)	723	0	46	35	22

🟢 2025-04-26 04:51:35 UTC Build successful.
🟢 2025-04-26 04:52:05 UTC ydbd size 3.8 GiB changed* by +12.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `290386c`	merge: `994e72d`	diff	diff %
ydbd size	4 120 274 248 Bytes	4 120 287 192 Bytes	+12.6 KiB	+0.000%
ydbd stripped size	1 428 517 272 Bytes	1 428 521 432 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

gridnevvvit · 2025-04-26T19:20:13Z

ydb/core/sys_view/show_create/create_table_formatter.cpp

+
+    Stream << " SET (\n";
+
+    TString del = "";


весь код ниже в этом cpp файле похож на дублирование. этого лучше избежать

Индексная таблица по умолчанию создается с автопартицированием по размеру, тут вывод настроек отличается от обычных таблиц.

так можно не дублировать и учесть и этот случай тоже?

В принципе можно вынести в общий случай, но тут дублирование 15 строчек, выглядит как усложнение кода, особенно если будут добавляться другие дефолтные значения для настроек в индексных таблицах

ydb/core/sys_view/show_create/create_table_formatter.cpp

github-actions · 2025-05-05T18:10:52Z

⚪ 2025-05-05 18:10:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 66a0e62 has started.
⚪ 2025-05-05 18:11:02 UTC Artifacts will be uploaded here
⚪ 2025-05-05 18:13:55 UTC ya make is running...
🟡 2025-05-05 19:28:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20641	19280	0	1	1325	35

⚪ 2025-05-05 19:29:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 19:53:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
156 (only retried tests)	116	0	1	8	31

⚪ 2025-05-05 19:53:40 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-05 20:26:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
150 (only retried tests)	120	0	0	0	30

🟢 2025-05-05 20:26:39 UTC Build successful.
🟢 2025-05-05 20:27:01 UTC ydbd size 2.2 GiB changed* by +9.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4c15602`	merge: `66a0e62`	diff	diff %
ydbd size	2 343 496 576 Bytes	2 343 505 832 Bytes	+9.0 KiB	+0.000%
ydbd stripped size	493 068 864 Bytes	493 070 592 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-05-05T18:11:00Z

⚪ 2025-05-05 18:11:00 UTC Pre-commit check linux-x86_64-release-asan for 66a0e62 has started.
⚪ 2025-05-05 18:11:10 UTC Artifacts will be uploaded here
⚪ 2025-05-05 18:13:59 UTC ya make is running...
🟡 2025-05-05 19:37:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12851	12656	0	119	49	27

⚪ 2025-05-05 19:38:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 20:08:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
958 (only retried tests)	863	0	46	24	25

⚪ 2025-05-05 20:08:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-05 20:33:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
713 (only retried tests)	606	0	46	39	22

🟢 2025-05-05 20:33:23 UTC Build successful.
🟢 2025-05-05 20:33:56 UTC ydbd size 3.8 GiB changed* by +12.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4c15602`	merge: `66a0e62`	diff	diff %
ydbd size	4 126 699 728 Bytes	4 126 712 696 Bytes	+12.7 KiB	+0.000%
ydbd stripped size	1 433 278 328 Bytes	1 433 282 488 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Initial commit

4fe7990

github-actions bot added the not-for-changelog label Apr 26, 2025

gridnevvvit reviewed Apr 26, 2025

View reviewed changes

ydb/core/sys_view/show_create/create_table_formatter.cpp Outdated Show resolved Hide resolved

shnikd requested a review from gridnevvvit May 4, 2025 11:17

shnikd enabled auto-merge (squash) May 5, 2025 10:24

Fixes

5513975

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support partition policy for Index Table in SHOW CREATE TABLE #17759

Support partition policy for Index Table in SHOW CREATE TABLE #17759

shnikd commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

gridnevvvit Apr 26, 2025 •

edited

Loading

shnikd May 1, 2025

gridnevvvit May 5, 2025

shnikd May 5, 2025

github-actions bot commented May 5, 2025 •

edited

Loading

github-actions bot commented May 5, 2025 •

edited

Loading

Support partition policy for Index Table in SHOW CREATE TABLE #17759

Are you sure you want to change the base?

Support partition policy for Index Table in SHOW CREATE TABLE #17759

Conversation

shnikd commented Apr 26, 2025 • edited Loading

Changelog category

Description for reviewers

github-actions bot commented Apr 26, 2025 • edited Loading

github-actions bot commented Apr 26, 2025 • edited Loading

github-actions bot commented Apr 26, 2025 • edited Loading

gridnevvvit Apr 26, 2025 • edited Loading

Choose a reason for hiding this comment

shnikd May 1, 2025

Choose a reason for hiding this comment

gridnevvvit May 5, 2025

Choose a reason for hiding this comment

shnikd May 5, 2025

Choose a reason for hiding this comment

github-actions bot commented May 5, 2025 • edited Loading

github-actions bot commented May 5, 2025 • edited Loading

shnikd commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

gridnevvvit Apr 26, 2025 •

edited

Loading

github-actions bot commented May 5, 2025 •

edited

Loading

github-actions bot commented May 5, 2025 •

edited

Loading