Use better and simpler logic for "default sort order", Deprecate most usages of TypeToken trickery #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvamelichev
changed the title
Entity.Id.getType() and use better and simpler logic for "default sort order"Entity.Id.getType() and use better and simpler logic for "default sort order"
nvamelichev
changed the title
Entity.Id.getType() and use better and simpler logic for "default sort order"
nvamelichev
added
refactoring
nvamelichev
force-pushed
the
minimize-calls-to-typetoken-via-Entity-Id-getType-make-default-sort-faster-in-presence-of-SecurityManager
branch
6 times, most recently
from
352fe67 to
0a24410
Compare
…er and simpler logic for "default sort order" ...because `Entity.Id.getType()` uses `TypeToken` which is **extremely slow** in tight loops when run via Bazel JUnit5 tests, which have a non-null `SecurityManager` installed (`SecurityManager` is to prevent `System.exit()` calls from tests, but it happens to check every reflective access made by `TypeToken`, of which there are **plenty**.)
nvamelichev
force-pushed
the
minimize-calls-to-typetoken-via-Entity-Id-getType-make-default-sort-faster-in-presence-of-SecurityManager
branch
from
0a24410 to
7b4d8f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because
Entity.Id.getType()usesTypeTokenwhich is extremely slow in tight loops when run via Bazel JUnit5 tests, which have a non-nullSecurityManagerinstalled (SecurityManageris to preventSystem.exit()calls from tests, but it happens to check every reflective access made byTypeToken, of which there are plenty.)