Skip to content
This repository was archived by the owner on Jun 10, 2018. It is now read-only.

Conversation

@bendilley
Copy link
Contributor

The driver for this change is that I wanted the console to inherit the default environment specified by set :default_env

This should also still use any loaded framework extensions like rbenv/rvm and bundler, via the SSHKit::Command interface.

@ydkn please could you consider this change for inclusion in your gem?

I wanted the console to inherit the default environment specified by
`set :default_env`

This should also use any loaded framework extensions like rbenv/rvm and
bundler.
No functional change, just implementing in a more typical style for a
capistrano task.
@ydkn
Copy link
Owner

ydkn commented Sep 22, 2014

thanks - looks interesting. Give me a few days to check it out in more detail.

@bendilley
Copy link
Contributor Author

Thanks! I'll admit I've only tested this with rbenv and bundler - there may be more involved in an rvm configuration.

@ydkn
Copy link
Owner

ydkn commented Sep 22, 2014

As you suspected, with rvm it doesn't work out of the box.
The capistrano-rvm gem is missing the rails command in rvm_map_bins - the capistrano-rbenv does include it in rbenv_map_bins.
Maybe they merge my pull request (capistrano/rvm#56) otherwise I prepared a version which does it by itself (1acbf5d) but this requires that capistrano-rvm is loaded before capistrano-rails-console which is not ideal.

Let's see what happens...

@bendilley
Copy link
Contributor Author

Fingers crossed...

@ydkn ydkn merged commit 1972047 into ydkn:master Dec 18, 2014
@ydkn
Copy link
Owner

ydkn commented Dec 18, 2014

The gem will now add rails to rvm_map_bins itself (dbe6b8b).

New release in a few minutes...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants