Fix for Web Workers #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygoe
reviewed
Apr 12, 2025
| // Global object | ||
| else if (typeof WorkerGlobalScope === "function" && self instanceof WorkerGlobalScope) { | ||
| // Web Worker scope | ||
| self.msgpack = msgpack; |
There was a problem hiding this comment.
Would it make sense (or is it even possible) to let the name "msgpack" be configured in this case as well like for the browser below?
There was a problem hiding this comment.
No, since a web worker runs in a different execution thread and has no access to the window object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issues #12 and #35
It now detects the Web Worker scope properly and can be imported in a Web Worker with
self.importScripts.Note: The minified build has not been rebuilt!