Fix ActiveField::checkbox() and ActiveField::radio() label not rendered due to generateLabel() API change in Yii2 22.0. - #576
Conversation
…ndered due to `generateLabel()` API change in Yii2 `22.0`.
|
@coderabbitai review |
✅ Action performedReview finished.
|
📝 WalkthroughWalkthrough
ChangesLabel rendering
CI workflow updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ActiveField.php`:
- Around line 109-114: Update the label-options initialization in both
checkbox() sites at src/components/ActiveField.php lines 109-114 and 126-131 to
merge the default tag into the existing effective label options instead of
replacing them. Preserve form-check-label from $this->labelOptions while
ensuring the label tag defaults to label for both methods.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 00d7f374-4c9b-4e60-8811-c72eab8cf1cf
📒 Files selected for processing (2)
CHANGELOG.mdsrc/components/ActiveField.php
|
@coderabbitai review |
✅ Action performedReview finished.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 22 #576 +/- ##
============================================
- Coverage 46.93% 46.36% -0.58%
Complexity 586 586
============================================
Files 45 45
Lines 2580 2532 -48
============================================
- Hits 1211 1174 -37
+ Misses 1369 1358 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build.yml:
- Around line 84-91: Update the Codecov action’s files input to reference the
coverage.clover output produced by the “Run unit tests with coverage” step, or
alternatively change PHPUnit’s coverage output to coverage.xml and keep the
existing input aligned with it. Ensure both steps use the same coverage
filename.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2f7e0b77-48eb-4191-ab21-2dcc2b7db822
📒 Files selected for processing (4)
.github/workflows/build.yml.github/workflows/zizmor.ymlCHANGELOG.mdsrc/components/ActiveField.php
🚧 Files skipped from review as they are similar to previous changes (2)
- src/components/ActiveField.php
- CHANGELOG.md
Summary by CodeRabbit