Fixed #312 ActiveFixture::load() doesn't populate data with _id#313
Open
Lisio wants to merge 1 commit intoyiisoft:masterfrom
Open
Fixed #312 ActiveFixture::load() doesn't populate data with _id#313Lisio wants to merge 1 commit intoyiisoft:masterfrom
Lisio wants to merge 1 commit intoyiisoft:masterfrom
Conversation
Lisio
commented
Jun 2, 2020
Lisio
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #312 |
Lisio
changed the title
Lisio
changed the title
samdark
approved these changes
Jun 10, 2020
|
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
Member
|
The fix looks good. @Lisio is it possible to add a test for it? Then I'll merge it. |
|
@samdark Is it possible to merge it? Or are you waiting for tests? |
Member
|
Yes, tests are necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.