Merged
Conversation
The sort comparator previously called count_exons() on every comparison, which scans the entire entry vector. For a gene with T transcripts and E entries per transcript, this was O(T·E·log T) work. Now exon counts are computed once per transcript before sorting, making it O(T·E + T·log T).
Collaborator
Author
Code Review — PR #22Verdict: Approve Diff: 1 file, +16/-11
No issues found🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes O(T·E·log T) rescans from the transcript sort comparator in
process_gene().Problem
The comparator called
count_exons()on every comparison, which scans the entire entry vector:For a gene with T transcripts and E entries per transcript, this was O(T·E·log T) work. For ENCODE genes with 10+ transcripts and 50+ entries each, that's ~250,000 exon-type checks per gene.
Fix
Precompute exon counts once per transcript before sorting:
Now it's O(T·E + T·log T) — the counting is done once, and the sort compares integers.
Impact
Estimated 2-3x speedup per gene in the transcript sort phase.
QC
🤖 Generated with Claude Code