Skip to content

Add semicolon to each statement while dumping the database #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add semicolon to each statement while dumping the database #33

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a94c0d4
Add semicolon to each statement while dumping the database
Feb 7, 2024
96d084e
Merge branch 'ylsideas:main' into main
lucacri Apr 24, 2024
b2f292c
feat: add Laravel 12 support
Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Schema/CockroachSchemaState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function dump(Connection $connection, $path): void
});

if ($statements !== []) {
$file .= PHP_EOL . $statements[0]['query'];
$file .= PHP_EOL . $statements[0]['query'] .(ends_with(trim($statements[0]['query']), ';') ? '' : ';');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ends_with will never work as the helper isn't installed in all applications with Laravel.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$file .= PHP_EOL . $statements[0]['query'] .(ends_with(trim($statements[0]['query']), ';') ? '' : ';');
$file .= PHP_EOL . Str::finish($statements[0]['query'], ';');

And import use Illuminate\Support\Str;

}

$this->files->put($path, $file);
Expand Down