Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DropdownMenu): move dropdown item overlay to dropdown menu #13411

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yuhengshen
Copy link
Contributor

将 drop menu item 的 overlay 共享,挂载到 drop-menu 上。避免切换菜单项时,屏幕闪烁。

修改前:

PixPin_2025-03-26_10-46-34

将下拉菜单项的遮罩层移至菜单组件中,避免切换下拉菜单时,页面闪烁
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (ec5b45b) to head (9a93771).
Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
packages/vant/src/dropdown-menu/DropdownMenu.tsx 70.58% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13411      +/-   ##
==========================================
+ Coverage   89.60%   89.64%   +0.03%     
==========================================
  Files         257      257              
  Lines        7013     7038      +25     
  Branches     1736     1745       +9     
==========================================
+ Hits         6284     6309      +25     
  Misses        384      384              
  Partials      345      345              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yuhengshen
Copy link
Contributor Author

/run-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants