[S-Series] Add total energy registers and fix power consumption units#269
Merged
Merged
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 69.78% 69.78%
=======================================
Files 14 14
Lines 1347 1347
=======================================
Hits 940 940
Misses 407 407 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yozik04
changed the title
Owner
|
Thank you @martinkiska ! |
21 tasks
5 tasks
yozik04
added a commit
that referenced
this pull request
Jan 11, 2026
… series (#276) ## Pull Request Type Please select the type of your PR: - [x] Add/Update Registries - [ ] Feature - [ ] Bug Fix ## Description **Heatpump model**: S320 <!-- e.g. F1145-6, F1255-6, F2040-6, S1155-6, S1255-6 --> **Firmware version**: 3.7.5<!-- e.g. 5.3.11, 5.4.4 --> <!-- Please describe your changes here. --> Recently I have updated new registers for S1256 model (#269). Colleague of mine is having similar S-series model S320. We verified that he has same new registers as I have for S1256 mode from the exportl. Thus my expectation is that same registers are there for all S series model, so I am aligning it for everyone. Change was verified for S320 and HA is reading correctly the values: <img width="597" height="531" alt="image (22)" src="https://github.com/user-attachments/assets/86c62b17-ddf1-4016-8198-d7c5d5ac1a73" /> <!-- IF THIS PR CHANGES REGISTERS. FOLLOW THE INSTRUCTIONS BELOW. ## How to add/update registers in the library To add/edit registers in the library first of all you need to find documentation how these parameters are officially called. There will be a backward compatibility break if a name will change. The process contains of mainly next steps: 1. Update source CSV files. 2. Convert CSV files to JSON. 3. Edit extensions.json if needed. 4. Submit PR. ### 1.A For F series pumps Use [ModbusManager](https://professional.nibe.eu/sv/proffshjalp/kommunikation/nibe-modbus). Do CSV export for the unit you want to update. Find the correct file in `nibe/data` folder. Merge data into that file (Do not change/update any lines. All CSV files are source files they must not be changed). ### 1.B For S serires pumps Change your pump language to English and do registers export. Merge that data into the correct file in `nibe/data` folder (Do not change/update any lines. All CSV files are source files they must not be changed). ### 2. Convert source CSV files to JSON ```bash python3 -m nibe.console_scripts.convert_csv ``` ### 3. Verify JSON files Verify that conversion was successful and required lines correctly appeared in the json files. If some modifications are required you need to edit `extensions.json` to fix these. ### 4. Submit PR Attach your source CSV file for reference so we could verify as well. --> [modbus_addresses_all_20251219-06919623073013-2.csv](https://github.com/user-attachments/files/24470464/modbus_addresses_all_20251219-06919623073013-2.csv) ## Checklist - [x] I have followed the instructions - [x] I ensured that my changes are well tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select the type of your PR:
Description
Heatpump model: S1256
Firmware version: 4.7.5
PR is fixing units of current power consumption and adding new total consumption registers for S1256 model. It was inspired by #181 and is fixing currently opened issue of one user #239. My expectation is that whole S series heat pump is using bad unit for this parameter. What is causing negative consumptions in energy tab. As a sideeffect if somebody was badly using those entities as source of data for energy dashboard, they will see warning with bad class, but it is just narrowing the data so they will be correct for the future.
Checklist
I am not sure why on single click on fixed entity I don't see correct graph data, but when opened for longer period it shows old data.
New Tot. consumption entities are ready to be used for energy dashboard
