Skip to content

[SMOS40] Update registers#273

Merged
yozik04 merged 2 commits into
masterfrom
jevgenik/smos40
Dec 25, 2025
Merged

[SMOS40] Update registers#273
yozik04 merged 2 commits into
masterfrom
jevgenik/smos40

Conversation

@yozik04
Copy link
Copy Markdown
Owner

@yozik04 yozik04 commented Dec 25, 2025

Continuation of #212

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.85%. Comparing base (d533593) to head (9573f74).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files          15       15           
  Lines        1406     1406           
=======================================
  Hits          940      940           
  Misses        466      466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yozik04 yozik04 mentioned this pull request Dec 25, 2025
5 tasks
@yozik04 yozik04 merged commit 0f5967d into master Dec 25, 2025
12 checks passed
@Nikoheld
Copy link
Copy Markdown

Nikoheld commented Dec 30, 2025

@yozik04 you referenced my pr in this but i don't see the missing lines merged into it. For example

 "40030": {
   "title": "Heating offset climate system 2",
   "factor": 1,
   "size": "s8",
   "min": -10.0,
   "max": 10.0,
   "default": 0.0,
   "name": "heating-offset-climate-system-2-40030",
   "write": true
 },

Should I manually merge my version with the current file and do another pr?

@yozik04
Copy link
Copy Markdown
Owner Author

yozik04 commented Jan 2, 2026

@Nikoheld Can you please update your HP firmware to the latest version and do another export please. Create a new issue with the CSV file and I will merge it myself.
They have changed "Size of variable" column in the new firmware's export an it is a total mess to merge your previous exported one.

@yozik04
Copy link
Copy Markdown
Owner Author

yozik04 commented Jan 2, 2026

@Nikoheld Actually no need. I merged yours in #274.

yozik04 added a commit that referenced this pull request Jan 2, 2026
## Pull Request Type

Please select the type of your PR:

- [x] Add/Update Registries
- [ ] Feature
- [ ] Bug Fix

## Description

Continuation of #273

**Heatpump model**: SMOS40

**Firmware version**: 4.4.7

## Checklist

- [x] I have followed the instructions
- [x] I ensured that my changes are well tested
@yozik04 yozik04 added this to the 2.21.0 milestone Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants