VVM S320 support#295
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 66.90% 66.92% +0.02%
==========================================
Files 15 15
Lines 1408 1409 +1
==========================================
+ Hits 942 943 +1
Misses 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you @MaximilianKoestler, I decided to merge into one file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select the type of your PR:
Description
Heatpump model: VVM S320 (new), VVM S325 (fixed unit)
Firmware version: 4.9.4 (VVM S320)
Add register dump for VVM S320. There are quite a few differences from the VVM S325 and as I can't test on the latter, I don't think merging the definitions at this point make sense.
Fix wrong unit for current power consumption (kWh -> kW) for both VVM S320 and VVM S325
Checklist
I ensured that my changes are well testedNot yet tested as I get strange errors running the example code under Windows. I can switch to a Linux setup if testing is strictly necessary for a pure register dump PR. I am planning to use this under home assistant, so I don't actually need to use the library directly.