[#20344] yugabyted: yugabyted UI support for K8s helm chart #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amannijhawan
requested changes
Jan 11, 2024
| @@ -8,7 +8,7 @@ nameOverride: "" | |||
|
|
|||
| Image: | |||
| repository: "yugabytedb/yugabyte" | |||
| tag: 2.19.3.0-b140 | |||
There was a problem hiding this comment.
please don't modify the values.yaml for this, this is modified by generated code.
| @@ -115,6 +115,22 @@ gflags: | |||
| tserver: {} | |||
| # use_cassandra_authentication: false | |||
|
|
|||
| yugabytedUi: | |||
| enabled: true | |||
There was a problem hiding this comment.
default should be false for yugabytedUI
| yugabytedUi: | ||
| enabled: true | ||
|
|
||
| metricsSnapshotter: |
There was a problem hiding this comment.
same here default should be false.
| @@ -504,6 +522,7 @@ helm2Legacy: false | |||
| ip_version_support: "v4_only" # v4_only, v6_only are the only supported values at the moment | |||
|
|
|||
| # For more https://docs.yugabyte.com/latest/reference/configuration/yugabyted/#environment-variables | |||
| # Note: for yugabyted-ui to work properly with credentials, ysql/ycql passwords must be the same | |||
There was a problem hiding this comment.
Why is this the case?
This can be a blocker for the operator integration?
|
Hi @djiang9001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the yugabyte helm chart to support yugabyted-ui:
tls.enabled=trueflag)yugabytedUi.enabled=falseflag)Sample command:
NOTE: Do not merge until
taginstable/yugabyte/values.yamlhas been updated to the correct value, as well asversionandappVersioninstable/yugabyte/Chart.yaml.