Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][2025.1] Auto analyze service tserver and master flags #25097

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

yifanguan
Copy link
Contributor

@yifanguan yifanguan commented Nov 26, 2024

This pull request add auto analyze service tserver flags yugabyte-db/docs/content/preview/reference/configuration/yb-tserver.md and master flags to yugabyte-db/docs/content/preview/reference/configuration/yb-master.md
DOC-527

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit fffddda
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/677300788f95420008928f1e
😎 Deploy Preview https://deploy-preview-25097--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ddhodge ddhodge added the area/documentation Documentation needed label Nov 26, 2024
Copy link
Contributor

@m-iancu m-iancu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes together with @yifanguan to try and improve clarity. Some might not be an improvement, @yifanguan to review and apply selectively.
Otherwise looks good from technical perspective.


##### ysql_cluster_level_mutation_persist_interval_ms

Interval at which the reported node level table mutation counts are persisted to the underlying auto-analyze mutations table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "auto-analyze mutations table"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a service table the auto analyze service uses to persist its state.

@ddhodge ddhodge removed the request for review from aishwarya24 January 9, 2025 05:35
@ddhodge ddhodge changed the title Add auto analyze service tserver and master flags [doc][2024.2.2] Auto analyze service tserver and master flags Feb 5, 2025
@ddhodge ddhodge requested a review from sudhanshu456 February 14, 2025 14:23
@@ -987,6 +987,18 @@ expensive when the number of yb-tservers, or the number of databases goes up.

{{< /note >}}

## Auto Analyze Service flags

Auto Analyze service flags are {{<tags/feature/tp>}}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this feature is still TP, @yifanguan, could you add an idea number to this feature tag, if there is one? See this example on how to do it: https://github.com/yugabyte/yugabyte-db/blob/3b2bac3e9288c3c68af9b89fb1c42fb8b87dbf0e/docs/content/stable/develop/best-practices-ysql.md?plain=1#L187C1-L187C358

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do the same in other places if you have mentioned feature tags in changes?

Default: false

##### ysql_enable_table_mutation_counter
Enable per table mutation (INSERT, UPDATE, DELETE) counting. The Auto Analyze service runs ANALYZE when the number of mutations of a table exceeds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line before the heading.

@ddhodge ddhodge changed the title [doc][2024.2.2] Auto analyze service tserver and master flags [doc][2025.1] Auto analyze service tserver and master flags Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants