#2250 - don't throw when HttpRequestRetry plugin is present#2251
Open
noffke wants to merge 1 commit intozalando:mainfrom
Open
#2250 - don't throw when HttpRequestRetry plugin is present#2251noffke wants to merge 1 commit intozalando:mainfrom
noffke wants to merge 1 commit intozalando:mainfrom
Conversation
noffke
requested review from
ChristianLohmann,
kasmarian,
lukasniemeier-zalando and
msdousti
as code owners
noffke
force-pushed
the
issue-2250
branch
2 times, most recently
from
c9067e8 to
abc2e56
Compare
kasmarian
reviewed
Mar 4, 2026
Member
kasmarian
left a comment
kasmarian
left a comment
There was a problem hiding this comment.
thank you for the contribution! The changes look, good IMO. Please adjust the imports
| import io.ktor.server.routing.post | ||
| import io.ktor.server.routing.routing | ||
| import io.ktor.utils.io.InternalAPI | ||
| import io.ktor.client.* |
Member
There was a problem hiding this comment.
Could you avoid using the start imports to be consistent with the rest of the codebase?
Contributor
Author
There was a problem hiding this comment.
@kasmarian thank you for your review! I've adapted the imports.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #2250
Description
Read response body fully instead of using
split.Motivation and Context
Fix for issue #2250
Types of changes
Checklist: