feature: forward backend for ingress as annotation zalando.org/skipper-backend #3665
Conversation
szuecs
added
the
major
…r-backend nop: increase readability Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
feature/forward-ingress
branch
from
c072c0b to
369f310
Compare
| } else if err != nil { | ||
| ic.logger.Errorf("Failed to convert default backend: %v", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
for readability, because route is not touched anymore until "return".
| logger: logger, | ||
| annotationFilters: annotationFilter(i.Metadata, logger), | ||
| annotationPredicate: annotationPredicate(i.Metadata), | ||
| annotationBackend: annotationBackendString(i.Metadata), |
There was a problem hiding this comment.
here we need annotationBackendString() to make it more clean
|
👍 |
|
I think we can add another test case for filter by annotation & predicate by annotation (feature where we add filter if some annotation exists) Also we need to extend validation webhook to only allow forward value for now. |
These test cases are in the PR. Maybe I miss understand your comment.
I don't see the need. This should not be used by ordinary users anyways. |
…r-backend (#3665) feature: [forward backend](https://opensource.zalando.com/skipper/reference/backends/#forward-backend) for ingress as annotation `zalando.org/skipper-backend`. RouteGroup validation makes sure that the backend type is recognized. dataclients/kubernetes/definitions/testdata/validation/test-forward.log is an empty file, because if log file does not exist test would be skipped. Signed-off-by: Sandor Szücs <[email protected]> Signed-off-by: Mustafa Abdelrahman <[email protected]>
3 participants
feature: forward backend for ingress as annotation
zalando.org/skipper-backend.RouteGroup validation makes sure that the backend type is recognized.
dataclients/kubernetes/definitions/testdata/validation/test-forward.log is an empty file, because if log file does not exist test would be skipped.