-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(library-solidity): resolve variable shadowing in TestAsyncDecrypt example #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The `latestRequestId` variable was shadowed, causing `myCustomCallback` checks to fail.
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @qiwihui on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves a variable shadowing issue in the TestAsyncDecrypt example where a local variable declaration was preventing proper assignment to a contract state variable.
- Removed local variable declaration to use the existing state variable
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
signed |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Thanks for your PR @qiwihui, could you please rephrase your commit with |
…ypt example" This reverts commit 9636c7d.
…t example The `latestRequestId` variable was shadowed, causing `myCustomCallback` checks to fail.
Sure. A new commit has been committed and the older one has been revert. Please squash the commits when merging. |
The
latestRequestId
variable was shadowed, causingmyCustomCallback
checks to fail.