Skip to content

Conversation

qiwihui
Copy link

@qiwihui qiwihui commented Oct 5, 2025

The latestRequestId variable was shadowed, causing myCustomCallback checks to fail.

The `latestRequestId` variable was shadowed, causing `myCustomCallback` checks to fail.
@Copilot Copilot AI review requested due to automatic review settings October 5, 2025 14:03
Copy link

cla-bot bot commented Oct 5, 2025

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @qiwihui on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves a variable shadowing issue in the TestAsyncDecrypt example where a local variable declaration was preventing proper assignment to a contract state variable.

  • Removed local variable declaration to use the existing state variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qiwihui
Copy link
Author

qiwihui commented Oct 5, 2025

signed

@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2025
Copy link

cla-bot bot commented Oct 6, 2025

The cla-bot has been summoned, and re-checked this pull request!

@aquint-zama
Copy link
Contributor

Thanks for your PR @qiwihui, could you please rephrase your commit with docs(library-solidity): …?

@qiwihui qiwihui changed the title docs(decryption): resolve variable shadowing in TestAsyncDecrypt example docs(library-solidity): resolve variable shadowing in TestAsyncDecrypt example Oct 6, 2025
…t example

The `latestRequestId` variable was shadowed, causing `myCustomCallback` checks to fail.
@qiwihui
Copy link
Author

qiwihui commented Oct 6, 2025

Thanks for your PR @qiwihui, could you please rephrase your commit with docs(library-solidity): …?

Sure. A new commit has been committed and the older one has been revert. Please squash the commits when merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants