refactor(host-contracts): rename ACL delegation methods and events #1079
Conversation
| vm.prank(sender); | ||
| vm.expectEmit(address(acl)); | ||
| emit ACLEvents.DelegatedAccount( | ||
| emit ACLEvents.DelegatedForUserDecryption( |
There was a problem hiding this comment.
is it possible to change the test name of the test function?
| delegate, | ||
| contractAddress, | ||
| delegationCounter, | ||
| ++delegation.delegationCounter, |
There was a problem hiding this comment.
is it possible to double check that the counter is indeed incremented inside storage, using vm.load cheatcode. Same thing in revoke test.
https://getfoundry.sh/reference/cheatcodes/load/
There was a problem hiding this comment.
Forget about using vm.load cheatcode, since this is inside nested mapping, too much headache.
Instead, just extend the ACL contract as a MockACL one which will expose easily a getter view function giving access at least to the struct counter, or even better the whole struct itself to check all its fields are correctly being updated as expected. For this I advise you to reuse same pattern as the foundry test for HCULimit, using an HCULimitMock contract extending original one here https://github.com/zama-ai/fhevm/blob/main/host-contracts/test/hcuLimit/HCULimit.t.sol#L17
So in summary we need 2 things:
- we need previous test with the
MockACLchecking that theDelegationstruct in storage is being updated as expected after each delegate/revoke tx (within a chain of delegate/revoke). - as discussed before lunch, also test that within a similar (or same) chain of delegate/revoke calls in some custom order, each event emits an increasing counter incrementing by
1each time.
| } | ||
| AclContractEvents::Initialized(_) | ||
| | AclContractEvents::DelegatedAccount(_) | ||
| | AclContractEvents::DelegatedForUserDecryption(_) |
There was a problem hiding this comment.
Can't we keep the same name as function ?
delegateForUserDecryption
There was a problem hiding this comment.
I think it is preferable to keep same convention as already existing events, such as Initialized, Allowed etc.
3 participants
Refs https://github.com/zama-ai/fhevm-internal/issues/474