Skip to content

Conversation

@isaacdecoded
Copy link
Contributor

@isaacdecoded isaacdecoded commented Nov 18, 2025

@cla-bot cla-bot bot added the cla-signed label Nov 18, 2025
@isaacdecoded isaacdecoded marked this pull request as ready for review November 20, 2025 09:36
@isaacdecoded isaacdecoded requested a review from a team as a code owner November 20, 2025 09:36
run: |
./fhevm-cli unpause gateway
# E2E tests after unpausing the Gateway contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is great as it will make e2e tests much longer, maybe we could instead start with the pausing tests and then run the usual tests after unpausing the contracts ?

);
inputAlice.add64(18446744073709550042n);

await expect(inputAlice.encrypt()).to.be.rejectedWith(new RegExp('Input request failed'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is not way to make sure the revert is coming from EnforcedPause revert from the gateway ?

privateKey,
publicKey,
),
).to.be.rejectedWith(new RegExp('User decrypt failed'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

const handleAddress = await this.httpPublicDecryptContract.xAddress();
const handle32 = await this.httpPublicDecryptContract.xUint32();
await expect(this.instances.alice.publicDecrypt([handleAddress, handle32, handleBool])).to.be.rejectedWith(
new RegExp('Public decrypt failed'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@melanciani
Copy link
Contributor

a bit harder to write the tests, but would it also make sense to have a test that :

  • ask for decryption/input proof
  • pause directly
  • checks test is ok
    to verify responses still come in after pausing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants